Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linefeed characters in url #311

Merged
merged 5 commits into from Aug 18, 2020

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Aug 18, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

We should remove \n,\r, \t from src/srcset

Breaking Changes

No

Additional Info

no

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #311 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files           7        7           
  Lines         385      385           
  Branches      101      101           
=======================================
  Hits          380      380           
  Misses          5        5           
Impacted Files Coverage Δ
src/utils.js 99.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c247cfa...9cf7212. Read the comment docs.

@alexander-akait alexander-akait merged commit b8ee9ee into master Aug 18, 2020
@alexander-akait alexander-akait deleted the fix-linefeed-characters-in-url branch August 18, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant