Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle attributes without tag #410

Merged
merged 2 commits into from Nov 2, 2021
Merged

fix: handle attributes without tag #410

merged 2 commits into from Nov 2, 2021

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #405

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #410 (8666258) into master (2fca322) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
+ Coverage   92.12%   92.13%   +0.01%     
==========================================
  Files           7        7              
  Lines         584      585       +1     
  Branches      187      187              
==========================================
+ Hits          538      539       +1     
  Misses         37       37              
  Partials        9        9              
Impacted Files Coverage Δ
src/plugins/sources-plugin.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fca322...8666258. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When extending default sources, tag is not optional
1 participant