From 23ea2cbdc2d3a8cf7fdd301c801978aed3b0103e Mon Sep 17 00:00:00 2001 From: Damian Pieczynski Date: Mon, 18 Jun 2018 05:58:02 +0200 Subject: [PATCH] fix: review changes --- src/index.js | 2 +- src/loader.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/index.js b/src/index.js index 488f8960..7fe3cf1e 100644 --- a/src/index.js +++ b/src/index.js @@ -147,7 +147,7 @@ class MiniCssExtractPlugin { ); } - module.buildInfo = module.buildInfo || { assets: {} }; + module.buildInfo = module.buildInfo || {}; module.buildInfo.assets = { ...module.buildInfo.assets, ...assets, diff --git a/src/loader.js b/src/loader.js index 70f37503..f8fb19b1 100644 --- a/src/loader.js +++ b/src/loader.js @@ -76,7 +76,7 @@ export function pitch(request) { ); let source; - let assets = {}; + const assets = {}; childCompiler.hooks.afterCompile.tap(pluginName, (compilation) => { source = compilation.assets[childFilename] && @@ -85,7 +85,7 @@ export function pitch(request) { // Collect assets from modules compilation.modules.forEach((module) => { if (module.buildInfo && module.buildInfo.assets) { - assets = { ...assets, ...module.buildInfo.assets }; + Object.assign(assets, module.buildInfo.assets); } });