From 62924409895ff6e0e4e599f6734c109ec40e6eff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=92=9F=E8=BF=9C=E7=BB=B4?= Date: Wed, 8 Mar 2023 04:09:02 +0800 Subject: [PATCH] fix: avoid to throw error when link doesn't have parentNode (#1016) --- src/index.js | 2 +- ...{0.4568ffdcdfced785eabc.css => 0.b1a0d51fa05593feebfa.css} | 0 .../{4568ffdcdfced785eabc.css => b1a0d51fa05593feebfa.css} | 0 .../expected/webpack-5-importModule/main.js | 4 ++-- ...{0.9ee2d65d5d13f2b4323d.css => 0.775d09b0a3e56e73fd45.css} | 0 .../{9ee2d65d5d13f2b4323d.css => 775d09b0a3e56e73fd45.css} | 0 test/cases/chunkFilename-fullhash/expected/webpack-5/main.js | 4 ++-- test/cases/hmr/expected/main.js | 2 +- test/cases/insert-function/expected/main.js | 2 +- test/cases/insert-string/expected/main.js | 2 +- test/cases/insert-undefined/expected/main.js | 2 +- 11 files changed, 9 insertions(+), 9 deletions(-) rename test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/{0.4568ffdcdfced785eabc.css => 0.b1a0d51fa05593feebfa.css} (100%) rename test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/{4568ffdcdfced785eabc.css => b1a0d51fa05593feebfa.css} (100%) rename test/cases/chunkFilename-fullhash/expected/webpack-5/{0.9ee2d65d5d13f2b4323d.css => 0.775d09b0a3e56e73fd45.css} (100%) rename test/cases/chunkFilename-fullhash/expected/webpack-5/{9ee2d65d5d13f2b4323d.css => 775d09b0a3e56e73fd45.css} (100%) diff --git a/src/index.js b/src/index.js index d89d4fa9..6a5969e1 100644 --- a/src/index.js +++ b/src/index.js @@ -862,7 +862,7 @@ class MiniCssExtractPlugin { 'err.code = "CSS_CHUNK_LOAD_FAILED";', "err.type = errorType;", "err.request = realHref;", - "linkTag.parentNode.removeChild(linkTag)", + "if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag)", "reject(err);", ]), "}", diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/0.4568ffdcdfced785eabc.css b/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/0.b1a0d51fa05593feebfa.css similarity index 100% rename from test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/0.4568ffdcdfced785eabc.css rename to test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/0.b1a0d51fa05593feebfa.css diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/4568ffdcdfced785eabc.css b/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/b1a0d51fa05593feebfa.css similarity index 100% rename from test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/4568ffdcdfced785eabc.css rename to test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/b1a0d51fa05593feebfa.css diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js b/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js index 462b4287..dab8a337 100644 --- a/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js +++ b/test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js @@ -73,7 +73,7 @@ __webpack_require__.r(__webpack_exports__); /******/ /******/ /* webpack/runtime/getFullHash */ /******/ (() => { -/******/ __webpack_require__.h = () => ("4568ffdcdfced785eabc") +/******/ __webpack_require__.h = () => ("b1a0d51fa05593feebfa") /******/ })(); /******/ /******/ /* webpack/runtime/global */ @@ -189,7 +189,7 @@ __webpack_require__.r(__webpack_exports__); /******/ err.code = "CSS_CHUNK_LOAD_FAILED"; /******/ err.type = errorType; /******/ err.request = realHref; -/******/ linkTag.parentNode.removeChild(linkTag) +/******/ if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag) /******/ reject(err); /******/ } /******/ } diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5/0.9ee2d65d5d13f2b4323d.css b/test/cases/chunkFilename-fullhash/expected/webpack-5/0.775d09b0a3e56e73fd45.css similarity index 100% rename from test/cases/chunkFilename-fullhash/expected/webpack-5/0.9ee2d65d5d13f2b4323d.css rename to test/cases/chunkFilename-fullhash/expected/webpack-5/0.775d09b0a3e56e73fd45.css diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5/9ee2d65d5d13f2b4323d.css b/test/cases/chunkFilename-fullhash/expected/webpack-5/775d09b0a3e56e73fd45.css similarity index 100% rename from test/cases/chunkFilename-fullhash/expected/webpack-5/9ee2d65d5d13f2b4323d.css rename to test/cases/chunkFilename-fullhash/expected/webpack-5/775d09b0a3e56e73fd45.css diff --git a/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js b/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js index 68c828cc..98b38564 100644 --- a/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js +++ b/test/cases/chunkFilename-fullhash/expected/webpack-5/main.js @@ -73,7 +73,7 @@ __webpack_require__.r(__webpack_exports__); /******/ /******/ /* webpack/runtime/getFullHash */ /******/ (() => { -/******/ __webpack_require__.h = () => ("9ee2d65d5d13f2b4323d") +/******/ __webpack_require__.h = () => ("775d09b0a3e56e73fd45") /******/ })(); /******/ /******/ /* webpack/runtime/global */ @@ -189,7 +189,7 @@ __webpack_require__.r(__webpack_exports__); /******/ err.code = "CSS_CHUNK_LOAD_FAILED"; /******/ err.type = errorType; /******/ err.request = realHref; -/******/ linkTag.parentNode.removeChild(linkTag) +/******/ if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag) /******/ reject(err); /******/ } /******/ } diff --git a/test/cases/hmr/expected/main.js b/test/cases/hmr/expected/main.js index 581539a3..4da2968a 100644 --- a/test/cases/hmr/expected/main.js +++ b/test/cases/hmr/expected/main.js @@ -952,7 +952,7 @@ __webpack_require__.r(__webpack_exports__); /******/ err.code = "CSS_CHUNK_LOAD_FAILED"; /******/ err.type = errorType; /******/ err.request = realHref; -/******/ linkTag.parentNode.removeChild(linkTag) +/******/ if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag) /******/ reject(err); /******/ } /******/ } diff --git a/test/cases/insert-function/expected/main.js b/test/cases/insert-function/expected/main.js index 96349f1f..ce2a297e 100644 --- a/test/cases/insert-function/expected/main.js +++ b/test/cases/insert-function/expected/main.js @@ -173,7 +173,7 @@ /******/ err.code = "CSS_CHUNK_LOAD_FAILED"; /******/ err.type = errorType; /******/ err.request = realHref; -/******/ linkTag.parentNode.removeChild(linkTag) +/******/ if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag) /******/ reject(err); /******/ } /******/ } diff --git a/test/cases/insert-string/expected/main.js b/test/cases/insert-string/expected/main.js index 04dd03fd..686c75ab 100644 --- a/test/cases/insert-string/expected/main.js +++ b/test/cases/insert-string/expected/main.js @@ -173,7 +173,7 @@ /******/ err.code = "CSS_CHUNK_LOAD_FAILED"; /******/ err.type = errorType; /******/ err.request = realHref; -/******/ linkTag.parentNode.removeChild(linkTag) +/******/ if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag) /******/ reject(err); /******/ } /******/ } diff --git a/test/cases/insert-undefined/expected/main.js b/test/cases/insert-undefined/expected/main.js index ea87a2bc..08a077d9 100644 --- a/test/cases/insert-undefined/expected/main.js +++ b/test/cases/insert-undefined/expected/main.js @@ -173,7 +173,7 @@ /******/ err.code = "CSS_CHUNK_LOAD_FAILED"; /******/ err.type = errorType; /******/ err.request = realHref; -/******/ linkTag.parentNode.removeChild(linkTag) +/******/ if (linkTag.parentNode) linkTag.parentNode.removeChild(linkTag) /******/ reject(err); /******/ } /******/ }