fix(index): assign empty module.id to prevent contenthash from ch…

…anging unnecessarily (#284) * fix: add empty id to prevent contenthash from changing unnecessarily * fix: updated tests
webpack-contrib · Oct 2, 2018 · d7946d0 · d7946d0
1 parent aa993da
commit d7946d0
Show file tree

Hide file tree

Showing 11 changed files with 6 additions and 9 deletions.
diff --git a/src/index.js b/src/index.js
@@ -42,6 +42,7 @@ class CssDependencyTemplate {
 class CssModule extends webpack.Module {
   constructor(dependency) {
     super(MODULE_TYPE, dependency.context);
+    this.id = '';
     this._identifier = dependency.identifier;
     this._identifierIndex = dependency.identifierIndex;
     this.content = dependency.content;
@@ -92,7 +93,7 @@ class CssModule extends webpack.Module {
     super.updateHash(hash);
     hash.update(this.content);
     hash.update(this.media || '');
-    hash.update(JSON.stringify(this.sourceMap || ''));
+    hash.update(this.sourceMap ? JSON.stringify(this.sourceMap) : '');
   }
 }
 

diff --git a/test/cases/composes-async/expected/1.css b/test/cases/composes-async/expected/1.css
@@ -1,4 +1,4 @@
-.base {
-  background: blue;
+.composed {
+  background: green;
 }
 
diff --git a/test/cases/composes-async/expected/2.css b/test/cases/composes-async/expected/2.css
@@ -1,4 +1,4 @@
-.composed {
-  background: green;
+.base {
+  background: blue;
 }
 
diff --git a/...entries/expected/651d2818ea64cfe50dbe.css → ...entries/expected/10adcc6fa8f8a3cf8d8d.css b/...entries/expected/651d2818ea64cfe50dbe.css → ...entries/expected/10adcc6fa8f8a3cf8d8d.css
diff --git a/...entries/expected/f36605fe5d863d4c4785.css → ...entries/expected/3023a4e1067adc5b1950.css b/...entries/expected/f36605fe5d863d4c4785.css → ...entries/expected/3023a4e1067adc5b1950.css
diff --git a/test/cases/contenthash-multiple-entries/expected/7bb844e9f5514d392e40.css b/test/cases/contenthash-multiple-entries/expected/7bb844e9f5514d392e40.css
diff --git a/.../expected/1.main.eaf8d14ae542d0855a7d.css → .../expected/1.main.e0d1c5b21d098a0a371f.css b/.../expected/1.main.eaf8d14ae542d0855a7d.css → .../expected/1.main.e0d1c5b21d098a0a371f.css
diff --git a/.../expected/2.main.ae0f5d087b9f049f864a.css → .../expected/2.main.9728193f8673cfdafd0e.css b/.../expected/2.main.ae0f5d087b9f049f864a.css → .../expected/2.main.9728193f8673cfdafd0e.css
diff --git a/...db65e2b053b76abc.8e8857ef6b5304f0d692.css → ...6e1512072d65b9db.35ee3780b5b76904cef5.css b/...db65e2b053b76abc.8e8857ef6b5304f0d692.css → ...6e1512072d65b9db.35ee3780b5b76904cef5.css
diff --git a/...sh/expected/style.3ffccb34a605ebf39f4d.js → ...sh/expected/style.25d094fb4a6ef6ef0222.js b/...sh/expected/style.3ffccb34a605ebf39f4d.js → ...sh/expected/style.25d094fb4a6ef6ef0222.js
diff --git a/...effaa38bf4f2edd8.18c4f2aa98e85a5465a6.css → ...674590ef68e758b3.ca7d26e87c697b1c7039.css b/...effaa38bf4f2edd8.18c4f2aa98e85a5465a6.css → ...674590ef68e758b3.ca7d26e87c697b1c7039.css