fix(loader): fix publicPath regression #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... when the publicPath is set to an empty string. The publicPath should resolve to an empty string in this case and _not_ `/`
alexander-akait
requested changes
Apr 25, 2019
|
Ignore CI problem , just add tests and we can release new version |
|
|
alexander-akait
previously approved these changes
Apr 26, 2019
|
Also please change email on commit and do force push, need accept CLA, thanks |
|
@evilebottnawi year, sorry about that. I think it is fixed now. |
Codecov Report
@@ Coverage Diff @@
## master #384 +/- ##
=======================================
Coverage 65.19% 65.19%
=======================================
Files 4 4
Lines 408 408
Branches 84 84
=======================================
Hits 266 266
Misses 118 118
Partials 24 24
Continue to review full report at Codecov.
|
This was referenced Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... when the publicPath is set to an empty string. The publicPath should resolve to an empty string in this case and not
/.This PR contains a:
Motivation / Use-Case
A regression caused by #373 makes it impossible to set
publicPathto an empty string. This fix brings this feature back.Breaking Changes
Additional Info