Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: downgrading normalize-url #399

Merged
merged 1 commit into from May 23, 2019
Merged

fix: downgrading normalize-url #399

merged 1 commit into from May 23, 2019

Conversation

ScriptedAlchemy
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Downgrading normalize-url to close issues opened around ES5 support required in IE

Breaking Changes

Additional Info

Internet Explorer is awesome...

fix #385

@ScriptedAlchemy
fix: downgrading normalize-url
83ff14b 
For ES5 support required in IE
@codecov
Copy link

codecov bot commented May 23, 2019 •
edited

Codecov Report

Merging #399 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #399   +/-   ##
=======================================
  Coverage   65.19%   65.19%           
=======================================
  Files           4        4           
  Lines         408      408           
  Branches       84       84           
=======================================
  Hits          266      266           
  Misses        118      118           
  Partials       24       24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 582ebfe...83ff14b. Read the comment docs.

@alexander-akait
Copy link
Member

Looks good, in future we should implement build stage for transpile package, but we can avoid this here

@alexander-akait
Copy link
Member

Also don't forget move https://github.com/webpack-contrib/mini-css-extract-plugin/blob/master/src/hmr/hotModuleReplacement.js#L145 before getReloadUrl, because in some cases el.href can be undefined or invalid

@alexander-akait
Copy link
Member

You can do this in other PR

@alexander-akait alexander-akait mentioned this pull request May 23, 2019
Closed
@alexander-akait alexander-akait merged commit 0dafaf6 into webpack-contrib:master May 23, 2019
@ScriptedAlchemy
Copy link
Contributor Author

Appreciate it. Been out of town this weekend. Will catch up as I do see there has been some activity.

@alexander-akait
Copy link
Member

Yes, I written test for home too

elliottsj added a commit to elliottsj/extract-css-chunks-webpack-plugin that referenced this pull request May 28, 2019
@elliottsj
Downgrade normalize-url to version 1.9.1
f7c4cf2 
Fixes faceyspacey#174

Similar to the fix for mini-css-extract-plugin:

- webpack-contrib/mini-css-extract-plugin#385
- webpack-contrib/mini-css-extract-plugin#399
@elliottsj elliottsj mentioned this pull request May 28, 2019
Merged
ScriptedAlchemy pushed a commit to faceyspacey/extract-css-chunks-webpack-plugin that referenced this pull request May 29, 2019
@elliottsj @ScriptedAlchemy
fix: downgrade normalize-url to version 1.9.1 (#176)
da5de61 
Fixes #174

Similar to the fix for mini-css-extract-plugin:

- webpack-contrib/mini-css-extract-plugin#385
- webpack-contrib/mini-css-extract-plugin#399
@snyk-bot snyk-bot mentioned this pull request Nov 15, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Nov 25, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Dec 11, 2019
Merged
@a-martynovich a-martynovich mentioned this pull request Mar 10, 2020
Merged
This was referenced Mar 25, 2020
Merged
Open
Open
@snyk-bot snyk-bot mentioned this pull request Apr 2, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 28, 2020
Merged
@birdofpreyru birdofpreyru mentioned this pull request Oct 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

normalize-url not working in IE11
2 participants
@ScriptedAlchemy @alexander-akait