fix: hmr reload with invalid link url #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
===========================================
+ Coverage 64.56% 88.04% +23.48%
===========================================
Files 4 4
Lines 412 410 -2
Branches 86 85 -1
===========================================
+ Hits 266 361 +95
+ Misses 120 47 -73
+ Partials 26 2 -24
Continue to review full report at Codecov.
|
|
Need add test with external hrer link, so please do not merge right now |
alexander-akait
force-pushed
the
fix-hmr-reload-with-invalid-link-url
branch
from
643545c
to
998494a
Compare
This was referenced Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
fixes #377 fixes #404
Breaking Changes
No
Additional Info
No