feat: Add ignoreOrder flag #422

mjhenkes · 2019-07-10T21:00:15Z

This PR contains a:

Motivation / Use-Case

Picking up the torch where #366 left off and making the changes suggested by @evilebottnawi
Also addresses #362
Borrowing @hedgepigdaniel 's description:

As has been pointed out in #250:

Sorting all imports (not just in files but in tree traversal import order is difficult to do in a large project, and impossible if there are async chunks with CSS.
Consistent use of scoping or naming conventions in CSS makes the order of CSS import irrelevant, and this is a much more manageable strategy for a large project as @jsg2021 said in New version 0.4.2 capture lot of warnings #250 (comment)
Using stats.warningFilter as recommended by @sokra in New version 0.4.2 capture lot of warnings #250 (comment) or webpack-filter-warnings-plugin does not work consistently. It's much better to avoid generating the warnings at their source (optionally) rather than to partially filter them later with regexes. For example, I use webpack-error-on-warnings-plugin to enforce that there are no warnings in a build. This is incompatible with filtering warnings, because it the error must happen in the before-emit hook so that it prevents emission of assets when there are warnings. The warnings filtering happens in the done hook or in the toJson method, which is too late.

Breaking Changes

None

Additional Info

The added tests is to ensure that enabling the flag doesn't make the plugin implode, but it doesn't really programmatically verify the warnings aren't printed.

fixes #362

jsf-clabot · 2019-07-10T21:00:19Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

styles

kubijo · 2019-07-15T12:47:16Z

Can someone from mainteiners merge this please.
The code seems nice, terse and without conflicts, so this should be a quick pass-over

alexander-akait

Please add test with ignoreOrder: false

mjhenkes · 2019-07-15T13:42:38Z

@evilebottnawi technically all the other tests are testing ignoreOrder: false, but i've added an explicit test.
I've also updated the package-lock file, it started failing due to npm audit.

alexander-akait

We need check stats.warning is empty or not in tests otherwise tests doesn't make sense

mjhenkes · 2019-07-15T14:48:42Z

@evilebottnawi added

alexander-akait

Good job, three notes

alexander-akait · 2019-07-15T15:00:28Z

test/IgnoreOrder.test.js

+      cache: false,
+    });
+    compiler.run((err1, stats) => {
+      expect(stats.hasWarnings()).toBeTruthy();


toBe(true)

just wondering why toBeTruthy(); is "better". Seems like the exact same shit to me...

@evilebottnawi

alexander-akait · 2019-07-15T15:00:36Z

test/IgnoreOrder.test.js

+      cache: false,
+    });
+    compiler.run((err1, stats) => {
+      expect(stats.hasWarnings()).toBeFalsy();


toBe(false)

alexander-akait · 2019-07-15T15:00:51Z

test/IgnoreOrder.test.js

@@ -0,0 +1,44 @@
+import path from 'path';


rename file ignoreOrder-option.test.js

alexander-akait

👍

mjhenkes · 2019-07-15T15:14:46Z

Do we need more approvals?

mjhenkes · 2019-07-15T15:46:16Z

Thanks @evilebottnawi! 🎉

kubijo · 2019-07-16T07:01:35Z

Yeah, thanks a lot guys!
What is the release process now?

alexander-akait · 2019-07-16T09:37:55Z

Today

feat: add ignoreOrder flag

0b98038

styles

piyushchauhan2011 mentioned this pull request Jul 11, 2019

Fix mini-css-extract-plugin warnings facebook/create-react-app#6791

Open

hedgepigdaniel mentioned this pull request Jul 15, 2019

feat: add orderWarnings flag #366

Closed

6 tasks

alexander-akait requested changes Jul 15, 2019

View reviewed changes

mjhenkes added 2 commits July 15, 2019 08:32

feat: add ignoreOrder False test

e11f3d5

feat: update package-lock

78e6c8f

alexander-akait requested changes Jul 15, 2019

View reviewed changes

feat: moar tests

98de7b4

feat: text change

e6aa3f6

alexander-akait requested changes Jul 15, 2019

View reviewed changes

feat: review updates

f5e23e8

alexander-akait approved these changes Jul 15, 2019

View reviewed changes

alexander-akait merged commit 4ad3373 into webpack-contrib:master Jul 15, 2019

sapkra mentioned this pull request Jul 16, 2019

mini-css-extract-plugin throws "Conflicting order" errors during build facebook/create-react-app#5372

Open

skovy mentioned this pull request Jul 25, 2019

Add the ignoreOrder option to MiniCssExtractPlugin DefinitelyTyped/DefinitelyTyped#37140

Merged

9 tasks

miloxeon mentioned this pull request Jul 26, 2019

How do I ignoreOrder in next.js? vercel/next-plugins#506

Closed

ocavue mentioned this pull request Oct 16, 2019

[Bug] Conflicting order between styles vuetifyjs/vuetify#5271

Closed

snyk-bot mentioned this pull request Nov 15, 2019

[Snyk] Upgrade mini-css-extract-plugin from 0.4.2 to 0.8.0 Matthelonianxl/cli-build-app#10

Open

snyk-bot mentioned this pull request Nov 25, 2019

[Snyk] Upgrade mini-css-extract-plugin from 0.5.0 to 0.8.0 adamlaska/github.com-aspnet-AspNetCore.Docs#19

Open

snyk-bot mentioned this pull request Dec 11, 2019

[Snyk] Upgrade mini-css-extract-plugin from 0.4.5 to 0.8.0 alfill/qr-code-scanner#2

Merged

Zacaria mentioned this pull request Dec 23, 2019

[mini-css-extract-plugin] warning Conflicting order vuejs/vue-cli#3771

Closed

a-martynovich mentioned this pull request Mar 10, 2020

[Snyk] Upgrade mini-css-extract-plugin from 0.5.0 to 0.9.0 WoTTsecurity/api#775

Merged

This was referenced Apr 2, 2020

[Snyk] Upgrade mini-css-extract-plugin from 0.7.0 to 0.9.0 Diegoalesco95/platzi-store#3

Open

[Snyk] Upgrade mini-css-extract-plugin from 0.8.0 to 0.9.0 cds-snc/node-starter-app#153

Open

snyk-bot mentioned this pull request Apr 9, 2020

[Snyk] Upgrade mini-css-extract-plugin from 0.8.0 to 0.9.0 cds-snc/a11y-tracker#16

Open

snyk-bot mentioned this pull request Apr 28, 2020

[Snyk] Upgrade mini-css-extract-plugin from 0.6.0 to 0.9.0 wallzack/travel-agency#2

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add ignoreOrder flag #422

feat: Add ignoreOrder flag #422

mjhenkes commented Jul 10, 2019 •

edited by alexander-akait

jsf-clabot commented Jul 10, 2019

kubijo commented Jul 15, 2019

alexander-akait left a comment

mjhenkes commented Jul 15, 2019

alexander-akait left a comment

mjhenkes commented Jul 15, 2019

alexander-akait left a comment

alexander-akait Jul 15, 2019

JimLynchCodes Oct 31, 2019

JimLynchCodes Oct 31, 2019

alexander-akait Jul 15, 2019

alexander-akait Jul 15, 2019

alexander-akait left a comment

mjhenkes commented Jul 15, 2019

mjhenkes commented Jul 15, 2019

kubijo commented Jul 16, 2019

alexander-akait commented Jul 16, 2019

feat: Add ignoreOrder flag #422

feat: Add ignoreOrder flag #422

Conversation

mjhenkes commented Jul 10, 2019 • edited by alexander-akait

Motivation / Use-Case

Breaking Changes

Additional Info

jsf-clabot commented Jul 10, 2019

kubijo commented Jul 15, 2019

alexander-akait left a comment

Choose a reason for hiding this comment

mjhenkes commented Jul 15, 2019

alexander-akait left a comment

Choose a reason for hiding this comment

mjhenkes commented Jul 15, 2019

alexander-akait left a comment

Choose a reason for hiding this comment

alexander-akait Jul 15, 2019

Choose a reason for hiding this comment

JimLynchCodes Oct 31, 2019

Choose a reason for hiding this comment

JimLynchCodes Oct 31, 2019

Choose a reason for hiding this comment

alexander-akait Jul 15, 2019

Choose a reason for hiding this comment

alexander-akait Jul 15, 2019

Choose a reason for hiding this comment

alexander-akait left a comment

Choose a reason for hiding this comment

mjhenkes commented Jul 15, 2019

mjhenkes commented Jul 15, 2019

kubijo commented Jul 16, 2019

alexander-akait commented Jul 16, 2019

mjhenkes commented Jul 10, 2019 •

edited by alexander-akait