Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not crash if pkg.(d|devD)ependencies unset #667

Merged
merged 2 commits into from Dec 11, 2023

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Sep 13, 2023

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fixes #547. dependencies and devDependencies are not required fields of package.json, but the existing code assumes they are always present, which can throw an uncaught error.

Breaking Changes

N/A

Additional Info

I no longer use this library, but I got tired of my stale ticket sitting around in my issues list 😜

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 13, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mcous / name: Michael Cousins (e71c85e)
  • ✅ login: alexander-akait / name: Alexander Akait (ee0c90f)

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (84f16be) 88.70% compared to head (ee0c90f) 88.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
+ Coverage   88.70%   88.73%   +0.03%     
==========================================
  Files           3        3              
  Lines         354      355       +1     
  Branches      115      116       +1     
==========================================
+ Hits          314      315       +1     
  Misses         37       37              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-akait alexander-akait merged commit 8ef0c7e into webpack-contrib:master Dec 11, 2023
17 checks passed
@mcous mcous deleted the fix-dep-check-crash branch December 11, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throws if either dependencies or devDependencies is not defined in package.json
3 participants