diff --git a/.circleci/config.yml b/.circleci/config.yml index 42c2615..5f85c10 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1,30 +1,35 @@ unit_tests: &unit_tests steps: - checkout - - setup_remote_docker - restore_cache: key: dependency-cache-{{ checksum "package-lock.json" }} - run: - name: NPM Rebuild - command: npm install + name: Install Latest NPM. + # npm@3 is buggy + command: if [[ $(npm -v | cut -c -1) > 3 ]] ; then npm i -g npm@latest; else echo "Skip npm updating"; fi - run: - name: Run unit tests. + name: NPM Install. + command: npm ci || npm i + - run: + name: Run Test. command: npm run ci:test -# canary_tests: &canary_tests -# steps: -# - checkout -# - setup_remote_docker -# - restore_cache: -# key: dependency-cache-{{ checksum "package-lock.json" }} -# - run: -# name: NPM Rebuild -# command: npm install -# - run: -# name: Install Webpack Canary -# command: npm i --no-save webpack@next -# - run: -# name: Run unit tests. -# command: npm run ci:test +canary_tests: &canary_tests + steps: + - checkout + - restore_cache: + key: dependency-cache-{{ checksum "package-lock.json" }} + - run: + name: Install Latest NPM. + command: npm i -g npm@latest + - run: + name: NPM Install. + command: npm ci + - run: + name: Install Webpack Canary. + command: npm i --no-save webpack@next + - run: + name: Run Test. + command: if [[ $(compver --name webpack --gte next --lt latest) < 1 ]] ; then printf "Next is older than Latest - Skipping Canary Suite"; else npm run ci:test; fi version: 2 jobs: @@ -33,98 +38,85 @@ jobs: - image: webpackcontrib/circleci-node-base:latest steps: - checkout - - setup_remote_docker - restore_cache: key: dependency-cache-{{ checksum "package-lock.json" }} - run: - name: Install Dependencies - command: npm install + name: Install Latest NPM. + command: npm i -g npm@latest + - run: + name: NPM Install. + command: npm ci - save_cache: key: dependency-cache-{{ checksum "package-lock.json" }} paths: - ./node_modules - + node6-latest: + docker: + - image: webpackcontrib/circleci-node6:latest + <<: *unit_tests node8-latest: docker: - image: webpackcontrib/circleci-node8:latest + <<: *unit_tests + node10-latest: + docker: + - image: webpackcontrib/circleci-node10:latest steps: - checkout - - setup_remote_docker - restore_cache: key: dependency-cache-{{ checksum "package-lock.json" }} - run: - name: NPM Rebuild - command: npm install + name: Install Latest NPM. + command: npm i -g npm@latest + - run: + name: NPM Install. + command: npm ci - run: - name: Run unit tests. + name: Run Test. command: npm run ci:coverage - run: name: Submit coverage data to codecov. command: bash <(curl -s https://codecov.io/bash) when: on_success - node6-latest: + node10-canary: docker: - - image: webpackcontrib/circleci-node6:latest - <<: *unit_tests - node9-latest: - docker: - - image: webpackcontrib/circleci-node9:latest - <<: *unit_tests - # node8-canary: - # docker: - # - image: webpackcontrib/circleci-node8:latest - # <<: *canary_tests + - image: webpackcontrib/circleci-node10:latest + <<: *canary_tests analysis: docker: - image: webpackcontrib/circleci-node-base:latest steps: - checkout - - setup_remote_docker - restore_cache: key: dependency-cache-{{ checksum "package-lock.json" }} - run: - name: NPM Rebuild - command: npm install + name: Install Latest NPM. + command: npm i -g npm@latest + - run: + name: NPM Install. + command: npm ci - run: name: Run linting. command: npm run lint - run: - name: Run NSP Security Check. + name: Run NPM Audit. command: npm run security - run: - name: Validate Commit Messages + name: Validate Commit Messages. command: npm run ci:lint:commits - publish: - docker: - - image: webpackcontrib/circleci-node-base:latest - steps: - - checkout - - setup_remote_docker - - restore_cache: - key: dependency-cache-{{ checksum "package-lock.json" }} - - run: - name: NPM Rebuild - command: npm install - - run: - name: Validate Commit Messages - command: npm run release:validate - - run: - name: Publish to NPM - command: printf "noop running conventional-github-releaser" -version: 2.0 workflows: version: 2 - validate-publish: + test: jobs: - dependency_cache - - node6-latest: + - analysis: requires: - dependency_cache filters: tags: only: /.*/ - - analysis: + - node6-latest: requires: - dependency_cache filters: @@ -137,25 +129,17 @@ workflows: filters: tags: only: /.*/ - - node9-latest: + - node10-latest: requires: - analysis - node6-latest filters: tags: only: /.*/ - # - node8-canary: - # requires: - # - analysis - # - node6-latest - # filters: - # tags: - # only: /.*/ - - publish: + - node10-canary: requires: - - node8-latest - - node9-latest + - analysis + - node6-latest filters: - branches: - only: - - master + tags: + only: /.*/ diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md new file mode 100644 index 0000000..e69279a --- /dev/null +++ b/.github/CONTRIBUTING.md @@ -0,0 +1,124 @@ +## Contributing in @webpack-contrib + +We'd always love contributions to further improve the webpack / webpack-contrib ecosystem! +Here are the guidelines we'd like you to follow: + +* [Questions and Problems](#question) +* [Issues and Bugs](#issue) +* [Feature Requests](#feature) +* [Pull Request Submission Guidelines](#submit-pr) +* [Commit Message Conventions](#commit) + +### Got a Question or Problem? + +Please submit support requests and questions to StackOverflow using the tag [[webpack]](http://stackoverflow.com/tags/webpack). +StackOverflow is better suited for this kind of support though you may also inquire in [Webpack Gitter](https://gitter.im/webpack/webpack). +The issue tracker is for bug reports and feature discussions. + +### Found an Issue or Bug? + +Before you submit an issue, please search the issue tracker, maybe an issue for your problem already exists and the discussion might inform you of workarounds readily available. + +We want to fix all the issues as soon as possible, but before fixing a bug we need to reproduce and confirm it. In order to reproduce bugs, we ask that you to provide a minimal reproduction scenario (github repo or failing test case). Having a live, reproducible scenario gives us a wealth of important information without going back & forth to you with additional questions like: + +- version of Webpack used +- version of the loader / plugin you are creating a bug report for +- the use-case that fails + +A minimal reproduce scenario allows us to quickly confirm a bug (or point out config problems) as well as confirm that we are fixing the right problem. + +We will be insisting on a minimal reproduce scenario in order to save maintainers time and ultimately be able to fix more bugs. We understand that sometimes it might be hard to extract essentials bits of code from a larger code-base but we really need to isolate the problem before we can fix it. + +Unfortunately, we are not able to investigate / fix bugs without a minimal reproduction, so if we don't hear back from you we are going to close an issue that doesn't have enough info to be reproduced. + +### Feature Requests? + +You can *request* a new feature by creating an issue on Github. + +If you would like to *implement* a new feature, please submit an issue with a proposal for your work `first`, to be sure that particular makes sense for the project. + +### Pull Request Submission Guidelines + +Before you submit your Pull Request (PR) consider the following guidelines: + +- Search Github for an open or closed PR that relates to your submission. You don't want to duplicate effort. +- Commit your changes using a descriptive commit message that follows our [commit message conventions](#commit). Adherence to these conventions is necessary because release notes are automatically generated from these messages. +- Fill out our `Pull Request Template`. Your pull request will not be considered if it is ignored. +- Please sign the `Contributor License Agreement (CLA)` when a pull request is opened. We cannot accept your pull request without this. Make sure you sign with the primary email address associated with your local / github account. + +### Webpack Contrib Commit Conventions + +Each commit message consists of a **header**, a **body** and a **footer**. The header has a special +format that includes a **type**, a **scope** and a **subject**: + +``` +(): + + + +