fix: compatibility with node@8 #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
force-pushed
the
issue-797
branch
from
467f480
to
d41b1e5
Compare
Codecov Report
@@ Coverage Diff @@
## master #798 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 10 10
Lines 178 178
Branches 63 63
=======================================
Hits 174 174
Misses 4 4Continue to review full report at Codecov.
|
|
Node 8 is EOL. Any reason to keep supporting it? |
|
Because it is breaking change |
This was referenced Mar 28, 2020
This was referenced Apr 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
fixes #797
Breaking Changes
No
Additional Info
No