Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add webpack resolver #231

Merged
merged 1 commit into from Sep 8, 2020
Merged

Conversation

cap-Bernardito
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Add webpack resolver

Breaking Changes

Drop webpack 2 plugin for setting options

Additional Info

No

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #231 into master will decrease coverage by 7.86%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
- Coverage   90.36%   82.50%   -7.87%     
==========================================
  Files           6        5       -1     
  Lines         436      200     -236     
  Branches       92       56      -36     
==========================================
- Hits          394      165     -229     
+ Misses         34       32       -2     
+ Partials        8        3       -5     
Impacted Files Coverage Δ
src/lib/resolver.js 92.68% <ø> (ø)
src/index.js 57.37% <56.89%> (-26.63%) ⬇️
src/utils.js 83.33% <83.33%> (ø)
src/evaluator.js 96.20% <96.20%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e9c183...e903c20. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for start

@alexander-akait alexander-akait merged commit da566a6 into master Sep 8, 2020
@alexander-akait alexander-akait deleted the feat-add-webpack-resolver branch September 8, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants