Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loader options validation #234

Merged
merged 1 commit into from Sep 9, 2020
Merged

Conversation

cap-Bernardito
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Add loader options validation

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #234 into master will increase coverage by 5.56%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
+ Coverage   82.53%   88.10%   +5.56%     
==========================================
  Files           5        5              
  Lines         189      185       -4     
  Branches       55       53       -2     
==========================================
+ Hits          156      163       +7     
+ Misses         31       22       -9     
+ Partials        2        0       -2     
Impacted Files Coverage Δ
src/utils.js 78.57% <ø> (-4.77%) ⬇️
src/index.js 77.96% <100.00%> (+18.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcf4daa...ffde2f0. Read the comment docs.

@alexander-akait alexander-akait merged commit 6980095 into master Sep 9, 2020
@alexander-akait alexander-akait deleted the feat-add-validation-options branch September 9, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants