Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: license files now have .txt suffix by default #210

Merged
merged 2 commits into from Jan 24, 2020
Merged

fix: license files now have .txt suffix by default #210

merged 2 commits into from Jan 24, 2020

Conversation

johnnyreilly
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Let me refer you to a twitter thread with @sokra 😄

https://twitter.com/wSokra/status/1220069497660411904

Send a PR to change the name to .LICENSE.txt by default.

Breaking Changes

n/a

Additional Info

@jsf-clabot
Copy link

jsf-clabot commented Jan 23, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

Merging #210 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #210      +/-   ##
=========================================
+ Coverage    98.2%   98.2%   +<.01%     
=========================================
  Files           7       7              
  Lines         390     391       +1     
  Branches      156     157       +1     
=========================================
+ Hits          383     384       +1     
  Misses          7       7
Impacted Files Coverage Δ
src/index.js 99.09% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aa35d4...c180b41. Read the comment docs.

README.md Outdated Show resolved Hide resolved
Co-Authored-By: Tobias Koppers <tobias.koppers@googlemail.com>
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants