Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass the terserOptions to the minify option #311

Merged
merged 1 commit into from Sep 11, 2020

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

allow to use terserOptions for custom minimizers

Breaking Changes

No

Additional Info

I will put esbuild example in near future

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #311 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   98.76%   98.76%           
=======================================
  Files           5        5           
  Lines         404      404           
  Branches      161      161           
=======================================
  Hits          399      399           
  Misses          5        5           
Impacted Files Coverage Δ
src/minify.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update defde64...2b05d4c. Read the comment docs.

@alexander-akait alexander-akait merged commit 4bd622c into master Sep 11, 2020
@alexander-akait alexander-akait deleted the feat-pass-terserOptions-to-minify-function branch September 11, 2020 19:00
peterblazejewicz added a commit to peterblazejewicz/DefinitelyTyped that referenced this pull request Sep 11, 2020
typescript-bot pushed a commit to DefinitelyTyped/DefinitelyTyped that referenced this pull request Sep 15, 2020
danielrearden pushed a commit to danielrearden/DefinitelyTyped that referenced this pull request Sep 22, 2020
…mizerOptions` option by @peterblazejewicz

- `minimizerOptions` added
- test amended
- cleanup

webpack-contrib/terser-webpack-plugin#311

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant