Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Map is inorrect when enable extractComments.banner of terser-webpack-plugin #589

Open
kerm1it opened this issue Jan 10, 2024 · 4 comments

Comments

@kerm1it
Copy link

kerm1it commented Jan 10, 2024

Bug report

webpack-terser-bug

What is the current behavior?

When my project using json file and use-sync-external-store@1.2.0, the source map is incorrect:

incorrect

Find a.json is mapped to use-sync-external-store incorrectly.

What is the expected behavior?

When disable extractComments options of terser-webpack-plugin,the behavior is correct.

correct

a.json is no-source, this is expected.

Other relevant information:
webpack version: 5.89.0
Node.js version: v18.18.0
Operating System: MacOS m2

@alexander-akait
Copy link
Member

I will look soon at this

@kerm1it
Copy link
Author

kerm1it commented Jan 10, 2024

Thanks

@kerm1it
Copy link
Author

kerm1it commented Jan 22, 2024

any progress?

@alexander-akait
Copy link
Member

Still in my TODO, a lot of issue, if you have a time feel free to investigate and send a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants