Skip to content
This repository was archived by the owner on Dec 5, 2019. It is now read-only.

Commit 1e58c99

Browse files
evilebottnawievilebottnawi
authoredDec 17, 2018
feat: chunkFilter option for filtering chunks (#382)
·
v2.2.0v2.1.0
1 parent 1282b87 commit 1e58c99

7 files changed

+210
-6
lines changed
 

‎README.md

+29
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,35 @@ module.exports = {
109109
};
110110
```
111111

112+
### `chunkFilter`
113+
114+
Type: `Function<(chunk) -> boolean>`
115+
Default: `() => true`
116+
117+
Allowing to filter which chunks should be uglified (by default all chunks are uglified).
118+
Return `true` to uglify the chunk, `false` otherwise.
119+
120+
**webpack.config.js**
121+
122+
```js
123+
module.exports = {
124+
optimization: {
125+
minimizer: [
126+
new UglifyJsPlugin({
127+
chunkFilter: (chunk) => {
128+
// Exclude uglification for the `vendor` chunk
129+
if (chunk.name === 'vendor') {
130+
return false;
131+
}
132+
133+
return true;
134+
}
135+
}),
136+
],
137+
},
138+
};
139+
```
140+
112141
### `cache`
113142

114143
Type: `Boolean|String`

‎src/index.js

+5
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ class UglifyJsPlugin {
2323
minify,
2424
uglifyOptions = {},
2525
test = /\.js(\?.*)?$/i,
26+
chunkFilter = () => true,
2627
warningsFilter = () => true,
2728
extractComments = false,
2829
sourceMap = false,
@@ -35,6 +36,7 @@ class UglifyJsPlugin {
3536

3637
this.options = {
3738
test,
39+
chunkFilter,
3840
warningsFilter,
3941
extractComments,
4042
sourceMap,
@@ -165,7 +167,10 @@ class UglifyJsPlugin {
165167
const processedAssets = new WeakSet();
166168
const tasks = [];
167169

170+
const { chunkFilter } = this.options;
171+
168172
Array.from(chunks)
173+
.filter((chunk) => chunkFilter && chunkFilter(chunk))
169174
.reduce((acc, chunk) => acc.concat(chunk.files || []), [])
170175
.concat(compilation.additionalChunkAssets || [])
171176
.filter(ModuleFilenameHelpers.matchObject.bind(null, this.options))

‎src/options.json

+3
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,9 @@
6464
}
6565
]
6666
},
67+
"chunkFilter": {
68+
"instanceof": "Function"
69+
},
6770
"cache": {
6871
"anyOf": [
6972
{

‎test/__snapshots__/chunkFilter-option.test.js.snap

+108
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
1+
// Jest Snapshot v1, https://goo.gl/fbAQLP
2+
3+
exports[`when applied with \`chunkFilter\` option matches snapshot for a single \`chunkFilter\`: entry.dd5931aa48f58d803916.js 1`] = `"!function(n){var r={};function o(e){if(r[e])return r[e].exports;var t=r[e]={i:e,l:!1,exports:{}};return n[e].call(t.exports,t,t.exports,o),t.l=!0,t.exports}o.m=n,o.c=r,o.d=function(e,t,n){o.o(e,t)||Object.defineProperty(e,t,{enumerable:!0,get:n})},o.r=function(e){\\"undefined\\"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:\\"Module\\"}),Object.defineProperty(e,\\"__esModule\\",{value:!0})},o.t=function(t,e){if(1&e&&(t=o(t)),8&e)return t;if(4&e&&\\"object\\"==typeof t&&t&&t.__esModule)return t;var n=Object.create(null);if(o.r(n),Object.defineProperty(n,\\"default\\",{enumerable:!0,value:t}),2&e&&\\"string\\"!=typeof t)for(var r in t)o.d(n,r,function(e){return t[e]}.bind(null,r));return n},o.n=function(e){var t=e&&e.__esModule?function(){return e.default}:function(){return e};return o.d(t,\\"a\\",t),t},o.o=function(e,t){return Object.prototype.hasOwnProperty.call(e,t)},o.p=\\"\\",o(o.s=1)}([,function(e,t){e.exports=function(){console.log(7)}}]);"`;
4+
5+
exports[`when applied with \`chunkFilter\` option matches snapshot for a single \`chunkFilter\`: errors 1`] = `Array []`;
6+
7+
exports[`when applied with \`chunkFilter\` option matches snapshot for a single \`chunkFilter\`: included.246349b8cbc039f3eb25.js 1`] = `
8+
"/******/ (function(modules) { // webpackBootstrap
9+
/******/ // The module cache
10+
/******/ var installedModules = {};
11+
/******/
12+
/******/ // The require function
13+
/******/ function __webpack_require__(moduleId) {
14+
/******/
15+
/******/ // Check if module is in cache
16+
/******/ if(installedModules[moduleId]) {
17+
/******/ return installedModules[moduleId].exports;
18+
/******/ }
19+
/******/ // Create a new module (and put it into the cache)
20+
/******/ var module = installedModules[moduleId] = {
21+
/******/ i: moduleId,
22+
/******/ l: false,
23+
/******/ exports: {}
24+
/******/ };
25+
/******/
26+
/******/ // Execute the module function
27+
/******/ modules[moduleId].call(module.exports, module, module.exports, __webpack_require__);
28+
/******/
29+
/******/ // Flag the module as loaded
30+
/******/ module.l = true;
31+
/******/
32+
/******/ // Return the exports of the module
33+
/******/ return module.exports;
34+
/******/ }
35+
/******/
36+
/******/
37+
/******/ // expose the modules object (__webpack_modules__)
38+
/******/ __webpack_require__.m = modules;
39+
/******/
40+
/******/ // expose the module cache
41+
/******/ __webpack_require__.c = installedModules;
42+
/******/
43+
/******/ // define getter function for harmony exports
44+
/******/ __webpack_require__.d = function(exports, name, getter) {
45+
/******/ if(!__webpack_require__.o(exports, name)) {
46+
/******/ Object.defineProperty(exports, name, { enumerable: true, get: getter });
47+
/******/ }
48+
/******/ };
49+
/******/
50+
/******/ // define __esModule on exports
51+
/******/ __webpack_require__.r = function(exports) {
52+
/******/ if(typeof Symbol !== 'undefined' && Symbol.toStringTag) {
53+
/******/ Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
54+
/******/ }
55+
/******/ Object.defineProperty(exports, '__esModule', { value: true });
56+
/******/ };
57+
/******/
58+
/******/ // create a fake namespace object
59+
/******/ // mode & 1: value is a module id, require it
60+
/******/ // mode & 2: merge all properties of value into the ns
61+
/******/ // mode & 4: return value when already ns object
62+
/******/ // mode & 8|1: behave like require
63+
/******/ __webpack_require__.t = function(value, mode) {
64+
/******/ if(mode & 1) value = __webpack_require__(value);
65+
/******/ if(mode & 8) return value;
66+
/******/ if((mode & 4) && typeof value === 'object' && value && value.__esModule) return value;
67+
/******/ var ns = Object.create(null);
68+
/******/ __webpack_require__.r(ns);
69+
/******/ Object.defineProperty(ns, 'default', { enumerable: true, value: value });
70+
/******/ if(mode & 2 && typeof value != 'string') for(var key in value) __webpack_require__.d(ns, key, function(key) { return value[key]; }.bind(null, key));
71+
/******/ return ns;
72+
/******/ };
73+
/******/
74+
/******/ // getDefaultExport function for compatibility with non-harmony modules
75+
/******/ __webpack_require__.n = function(module) {
76+
/******/ var getter = module && module.__esModule ?
77+
/******/ function getDefault() { return module['default']; } :
78+
/******/ function getModuleExports() { return module; };
79+
/******/ __webpack_require__.d(getter, 'a', getter);
80+
/******/ return getter;
81+
/******/ };
82+
/******/
83+
/******/ // Object.prototype.hasOwnProperty.call
84+
/******/ __webpack_require__.o = function(object, property) { return Object.prototype.hasOwnProperty.call(object, property); };
85+
/******/
86+
/******/ // __webpack_public_path__
87+
/******/ __webpack_require__.p = \\"\\";
88+
/******/
89+
/******/
90+
/******/ // Load entry module and return exports
91+
/******/ return __webpack_require__(__webpack_require__.s = 0);
92+
/******/ })
93+
/************************************************************************/
94+
/******/ ([
95+
/* 0 */
96+
/***/ (function(module, exports) {
97+
98+
module.exports = function Bar1() {
99+
var b = 2 + 2;
100+
console.log(b + 1 + 2);
101+
};
102+
103+
104+
/***/ })
105+
/******/ ]);"
106+
`;
107+
108+
exports[`when applied with \`chunkFilter\` option matches snapshot for a single \`chunkFilter\`: warnings 1`] = `Array []`;

‎test/__snapshots__/validation.test.js.snap

+13-6
Original file line numberDiff line numberDiff line change
@@ -3,20 +3,27 @@
33
exports[`validation 1`] = `
44
"UglifyJs Plugin Invalid Options
55
6-
options should NOT have additional properties
6+
options.chunkFilter should pass \\"instanceof\\" keyword validation
77
"
88
`;
99

1010
exports[`validation 2`] = `
1111
"UglifyJs Plugin Invalid Options
1212
13+
options should NOT have additional properties
14+
"
15+
`;
16+
17+
exports[`validation 3`] = `
18+
"UglifyJs Plugin Invalid Options
19+
1320
options.cache should be boolean
1421
options.cache should be string
1522
options.cache should match some schema in anyOf
1623
"
1724
`;
1825

19-
exports[`validation 3`] = `
26+
exports[`validation 4`] = `
2027
"UglifyJs Plugin Invalid Options
2128
2229
options.parallel should be boolean
@@ -25,7 +32,7 @@ options.parallel should match some schema in anyOf
2532
"
2633
`;
2734

28-
exports[`validation 4`] = `
35+
exports[`validation 5`] = `
2936
"UglifyJs Plugin Invalid Options
3037
3138
options.parallel should be boolean
@@ -34,21 +41,21 @@ options.parallel should match some schema in anyOf
3441
"
3542
`;
3643

37-
exports[`validation 5`] = `
44+
exports[`validation 6`] = `
3845
"UglifyJs Plugin Invalid Options
3946
4047
options.sourceMap should be boolean
4148
"
4249
`;
4350

44-
exports[`validation 6`] = `
51+
exports[`validation 7`] = `
4552
"UglifyJs Plugin Invalid Options
4653
4754
options.uglifyOptions should be object
4855
"
4956
`;
5057

51-
exports[`validation 7`] = `
58+
exports[`validation 8`] = `
5259
"UglifyJs Plugin Invalid Options
5360
5461
options.warningsFilter should pass \\"instanceof\\" keyword validation

‎test/chunkFilter-option.test.js

+44
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
import UglifyJsPlugin from '../src/index';
2+
3+
import { cleanErrorStack, createCompiler, compile } from './helpers';
4+
5+
describe('when applied with `chunkFilter` option', () => {
6+
let compiler;
7+
8+
beforeEach(() => {
9+
compiler = createCompiler({
10+
entry: {
11+
included: `${__dirname}/fixtures/included1.js`,
12+
entry: `${__dirname}/fixtures/entry.js`,
13+
},
14+
});
15+
});
16+
17+
it('matches snapshot for a single `chunkFilter`', () => {
18+
new UglifyJsPlugin({
19+
chunkFilter: (chunk) => {
20+
if (chunk.name === 'included') {
21+
return false;
22+
}
23+
24+
return true;
25+
},
26+
}).apply(compiler);
27+
28+
return compile(compiler).then((stats) => {
29+
const errors = stats.compilation.errors.map(cleanErrorStack);
30+
const warnings = stats.compilation.warnings.map(cleanErrorStack);
31+
32+
expect(errors).toMatchSnapshot('errors');
33+
expect(warnings).toMatchSnapshot('warnings');
34+
35+
for (const file in stats.compilation.assets) {
36+
if (
37+
Object.prototype.hasOwnProperty.call(stats.compilation.assets, file)
38+
) {
39+
expect(stats.compilation.assets[file].source()).toMatchSnapshot(file);
40+
}
41+
}
42+
});
43+
});
44+
});

‎test/validation.test.js

+8
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,14 @@ it('validation', () => {
2626
new UglifyJsPlugin({ exclude: [/foo/] });
2727
}).not.toThrow();
2828

29+
expect(() => {
30+
new UglifyJsPlugin({ chunkFilter: () => {} });
31+
}).not.toThrow();
32+
33+
expect(() => {
34+
new UglifyJsPlugin({ chunkFilter: true });
35+
}).toThrowErrorMatchingSnapshot();
36+
2937
expect(() => {
3038
new UglifyJsPlugin({ doesntExist: true });
3139
}).toThrowErrorMatchingSnapshot();

0 commit comments

Comments
 (0)
This repository has been archived.