This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
fix(index): tapable deprecation warnings (webpack >= v4.0.0)
#238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this changes in Size Limit branch and everything works. |
|
The diff is a little bit tricky. I just move logic to functions and make |
michael-ciniawsky
changed the title
webpack >= v4.0.0)
michael-ciniawsky
approved these changes
Feb 23, 2018
src/index.js
Outdated
| }; | ||
|
|
||
| if (compiler.hooks) { | ||
| const name = 'uglifyjs-webpack-plugin'; |
There was a problem hiding this comment.
- const name = 'uglifyjs-webpack-plugin';
+ const plugin = { name: 'UglifyJSPlugin' };
// ...hook.tap(plugin, cb)
src/index.js
Outdated
| compiler.hooks.compilation.tap(name, (compilation) => { | ||
| if (this.options.sourceMap) { | ||
| compilation.hooks.buildMobule.tap(name, buildMobuleFn); | ||
| } |
| compiler.plugin('compilation', (compilation) => { | ||
| if (this.options.sourceMap) { | ||
| compilation.plugin('build-module', buildMobuleFn); | ||
| } |
|
@michael-ciniawsky |
michael-ciniawsky
changed the title
webpack >= v4.0.0)tapable deprecation warnings (webpack >= v4.0.0)
|
Released in |
michael-ciniawsky
added
status: Approved
and removed
pr_action: Review
priority: 3 (required)
severity: 4 (inconvenient)
labels
|
Thanks to be sooooo fast 😺 |
|
For sure, these annoying warnings... 😛 |
This was referenced Feb 24, 2018
This was referenced Mar 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the plugin shows this warning when I try to run it with webpack 4.0.0-beta2:
This fix will support both webpack 3 and webpack 4 APIs without any warning. This way to deal with the API is recommended by @sokra webpack-contrib/webpack-bundle-analyzer#154 (comment)
I need this PR to add
.mjssupport to Size Limit ai/size-limit#42@michael-ciniawsky nice to see you here, you do a lot of work =^_^=