This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
fix: return missing important information #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooflorent
reviewed
Jun 15, 2018
src/index.js
Outdated
| @@ -106,7 +106,7 @@ class UglifyJsPlugin { | |||
| } | |||
| } | |||
|
|
|||
| return warningMessage; | |||
| return `｢UglifyJs｣ ${warningMessage} in ${file}`; | |||
There was a problem hiding this comment.
Not sure about the brackets. validateOptions does not add them.
There was a problem hiding this comment.
@ooflorent just use UglifyJs?
There was a problem hiding this comment.
Maybe UglifyJs Plugin just as here:
uglifyjs-webpack-plugin/src/index.js
Line 21 in 6ab0918
alexander-akait
force-pushed
the
issue-281
branch
from
241d40f
to
bb2b66e
Compare
|
@ooflorent done 👍 |
ooflorent
approved these changes
Jun 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #281
compilation.warningfor plugins and who run webpack using own script (i have many questions in gitter how it is better do and one warning on an assets is best solution)UglifyJS