Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReDoS Vulnerability #412

Closed
pedantic79 opened this issue Sep 9, 2021 · 2 comments · Fixed by #413 or magma/magma#10517
Closed

ReDoS Vulnerability #412

pedantic79 opened this issue Sep 9, 2021 · 2 comments · Fixed by #413 or magma/magma#10517

Comments

@pedantic79
Copy link

How Do We Reproduce?

This is a vulnerability in ansi-html, which this package depends on. To repro, you can use the command below as described Tjatse/ansi-html#19.

Unfortunately, ansi-html seems to be unmaintained. There were several options discussed about what to do here webpack/webpack-dev-server#3576 and was fixed by switching to a fork of ansi-html called ansi-html-community. It was merged here webpack/webpack-dev-server#3801

While this package shouldn't be running in production, using unmaintained packages is an issue and vulnerability scanners pickup the fact that any project using webpack-hot-middleware is pulling in the vulnerable ansi-html package.

nttibbetts added a commit to nttibbetts/webpack-hot-middleware that referenced this issue Sep 9, 2021
This fixes the vulnerability reported in [CVE-2021-23424][CVE], by
replacing the ansi-html dependency with a fork of the project that has
the [suggested fix][ansi-html-fix] and resolves [webpack-contrib#412][412]

[CVE]: https://nvd.nist.gov/vuln/detail/CVE-2021-23424
[ansi-html-fix]: Tjatse/ansi-html#19
[412]: webpack-contrib#412
nttibbetts added a commit to nttibbetts/webpack-hot-middleware that referenced this issue Sep 9, 2021
This fixes the vulnerability reported in [CVE-2021-23424][CVE], by
replacing the ansi-html dependency with a fork of the project that has
the [suggested fix][ansi-html-fix] and resolves [webpack-contrib#412][412]

[CVE]: https://nvd.nist.gov/vuln/detail/CVE-2021-23424
[ansi-html-fix]: Tjatse#19
[412]: webpack-hot-middleware#412
nttibbetts added a commit to nttibbetts/webpack-hot-middleware that referenced this issue Sep 9, 2021
This fixes the vulnerability reported in [CVE-2021-23424][CVE], by
replacing the ansi-html dependency with a fork of the project that has
the [suggested fix][ansi-html-fix] and resolves [webpack-contrib#412][412]

[CVE]: https://nvd.nist.gov/vuln/detail/CVE-2021-23424
[ansi-html-fix]: Tjatse/ansi-html#19
[412]: webpack-contrib#412
nttibbetts added a commit to nttibbetts/webpack-hot-middleware that referenced this issue Sep 9, 2021
This fixes the vulnerability reported in [CVE-2021-23424][CVE] by
replacing the ansi-html dependency with a fork of the project that has
the [suggested fix][ansi-html-fix] and resolves [webpack-contrib#412][412]

[CVE]: https://nvd.nist.gov/vuln/detail/CVE-2021-23424
[ansi-html-fix]: Tjatse/ansi-html#19
[412]: webpack-contrib#412
nttibbetts added a commit to nttibbetts/webpack-hot-middleware that referenced this issue Sep 9, 2021
This is a fix for the vulnerability reported in [CVE-2021-23424][CVE] by
replacing the ansi-html dependency with a fork of the project that has
the [suggested fix][ansi-html-fix] and resolves [webpack-contrib#412][412]

[CVE]: https://nvd.nist.gov/vuln/detail/CVE-2021-23424
[ansi-html-fix]: Tjatse/ansi-html#19
[412]: webpack-contrib#412
@createthis
Copy link

Will there be a release based on this?

@glenjamin
Copy link
Collaborator

Released in 2.25.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants