Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct plugin order for CSS Modules #534

Merged
merged 1 commit into from May 23, 2017
Merged

fix: correct plugin order for CSS Modules #534

merged 1 commit into from May 23, 2017

Conversation

OliverJAsh
Copy link
Contributor

Fixes #533

@jsf-clabot
Copy link

jsf-clabot commented May 16, 2017 •
edited

CLA assistant check
All committers have signed the CLA.

@OliverJAsh OliverJAsh mentioned this pull request May 16, 2017
Closed
@alexander-akait
Copy link
Member

alexander-akait commented May 16, 2017 •
edited

@OliverJAsh We are preparing for release css-loader v1, new version don't support css-modules. If your want to work with css-modules best use postcss-loader with postcss-modules(https://github.com/css-modules/postcss-modules). Also your can help our with webpack-contrib/postcss-loader#227.

Now we accept only critical bug fixes for css-loader.

@alexander-akait
Copy link
Member

alexander-akait commented May 16, 2017 •
edited

@OliverJAsh new version of loader will be support only icss spec (https://github.com/css-modules/icss)

@michael-ciniawsky michael-ciniawsky changed the title Fix CSS Modules plugin order fix: CSS Modules plugin order May 22, 2017
@michael-ciniawsky michael-ciniawsky self-assigned this May 22, 2017
@michael-ciniawsky michael-ciniawsky added this to the 0.29.0 milestone May 22, 2017
@michael-ciniawsky
Copy link
Member

@OliverJAsh Did you test this change with a larger code base for breaking changes, it eventually isn't breaking and could go as a semver minor

@OliverJAsh
Copy link
Contributor Author

I have only tested against one large code base. Others may like to try it out

michael-ciniawsky
michael-ciniawsky approved these changes May 22, 2017
View reviewed changes
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS Modules Maintainer gave me a rubberstamp 👍 on this, since postcss-modules-values is basically independent (but should be the first). This PR would change the plugin order to align with css-modules-require-hook/css-modules-loader-core and is recommended. Still the risk that whatever current bloatbase might be out there could possibly break 😛

@michael-ciniawsky michael-ciniawsky changed the title fix: CSS Modules plugin order fix: correct plugin order for CSS Modules May 23, 2017
@michael-ciniawsky michael-ciniawsky merged commit b90f492 into webpack-contrib:master May 23, 2017
@michael-ciniawsky
Copy link
Member

These may need a short handwritten note in the release notes, to be aware of edge cases otherwise I respond to eventual issues :)

@michael-ciniawsky
Copy link
Member

@OliverJAsh Thx

@OliverJAsh
Copy link
Contributor Author

Great, thanks! When will this be released, do you know?

@joshwiens
Copy link
Member

Right about now - https://github.com/webpack-contrib/css-loader/blob/v0.28.3/CHANGELOG.md#0283-2017-05-25

This was referenced May 26, 2017
Closed
Closed
@michael-ciniawsky michael-ciniawsky removed this from Bug in Dashboard May 27, 2017
@michael-ciniawsky michael-ciniawsky modified the milestone: 0.29.0 May 27, 2017
eliperelman pushed a commit to neutrinojs/neutrino that referenced this pull request Jul 10, 2018
@renovate @eliperelman
Update dependency css-loader to v1 (#988)
c4d0f30 
This Pull Request updates dependency [css-loader](https://github.com/webpack-contrib/css-loader) from `^0.28.11` to `^1.0.0`



<details>
<summary>Release Notes</summary>

### [`v1.0.0`](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md#&#8203;100httpsgithubcomwebpack-contribcss-loadercomparev02811v100-2018-07-06)
[Compare Source](webpack-contrib/css-loader@v0.28.11...v1.0.0)
##### BREAKING CHANGES

* remove `minimize` option, use [`postcss-loader`](https://github.com/postcss/postcss-loader) with [`cssnano`](https://github.com/cssnano/cssnano) or use [`optimize-cssnano-plugin`](https://github.com/intervolga/optimize-cssnano-plugin) plugin
* remove `module` option, use `modules` option instead
* remove `camelcase` option, use `camelCase` option instead
* remove `root` option, use [`postcss-loader`](https://github.com/postcss/postcss-loader) with [`postcss-url`](https://github.com/postcss/postcss-url) plugin
* remove `alias` option, use [`resolve.alias`](https://webpack.js.org/configuration/resolve/) feature or use [`postcss-loader`](https://github.com/postcss/postcss-loader) with [`postcss-url`](https://github.com/postcss/postcss-url) plugin
* update `postcss` to `6` version
* minimum require `nodejs` version is `6.9`
* minimum require `webpack` version is `4`
#### [0.28.11](webpack-contrib/css-loader@v0.28.10...v0.28.11) (2018-03-16)
##### Bug Fixes

* **lib/processCss:** don't check `mode` for `url` handling (`options.modules`) ([#&#8203;698](`webpack-contrib/css-loader#698)) ([c788450](webpack-contrib/css-loader@c788450))
#### [0.28.10](webpack-contrib/css-loader@v0.28.9...v0.28.10) (2018-02-22)
##### Bug Fixes

* **getLocalIdent:** add `rootContext` support (`webpack >= v4.0.0`) ([#&#8203;681](`webpack-contrib/css-loader#681)) ([9f876d2](webpack-contrib/css-loader@9f876d2))
#### [0.28.9](webpack-contrib/css-loader@v0.28.8...v0.28.9) (2018-01-17)
##### Bug Fixes

* ignore invalid URLs (`url()`) ([#&#8203;663](`webpack-contrib/css-loader#663)) ([d1d8221](webpack-contrib/css-loader@d1d8221))
#### [0.28.8](webpack-contrib/css-loader@v0.28.7...v0.28.8) (2018-01-05)
##### Bug Fixes

* **loader:** correctly check if source map is `undefined` ([#&#8203;641](`webpack-contrib/css-loader#641)) ([0dccfa9](webpack-contrib/css-loader@0dccfa9))
* proper URL escaping and wrapping (`url()`) ([#&#8203;627](`webpack-contrib/css-loader#627)) ([8897d44](webpack-contrib/css-loader@8897d44))
#### [0.28.7](webpack-contrib/css-loader@v0.28.6...v0.28.7) (2017-08-30)
##### Bug Fixes

* pass resolver to `localsLoader` (`options.alias`)  ([#&#8203;601](`webpack-contrib/css-loader#601)) ([8f1b57c](webpack-contrib/css-loader@8f1b57c))
#### [0.28.6](webpack-contrib/css-loader@v0.28.5...v0.28.6) (2017-08-30)
##### Bug Fixes

* add support for aliases starting with `/` (`options.alias`) ([#&#8203;597](`webpack-contrib/css-loader#597)) ([63567f2](webpack-contrib/css-loader@63567f2))
#### [0.28.5](webpack-contrib/css-loader@v0.28.4...v0.28.5) (2017-08-17)
##### Bug Fixes

* match mutliple dashes (`options.camelCase`) ([#&#8203;556](`webpack-contrib/css-loader#556)) ([1fee601](webpack-contrib/css-loader@1fee601))
* stricter `[@import]` tolerance ([#&#8203;593](`webpack-contrib/css-loader#593)) ([2e4ec09](webpack-contrib/css-loader@2e4ec09))
#### [0.28.4](webpack-contrib/css-loader@v0.28.3...v0.28.4) (2017-05-30)
##### Bug Fixes

* preserve leading underscore in class names ([#&#8203;543](`webpack-contrib/css-loader#543)) ([f6673c8](webpack-contrib/css-loader@f6673c8))
#### [0.28.3](webpack-contrib/css-loader@v0.28.2...v0.28.3) (2017-05-25)
##### Bug Fixes

* correct plugin order for CSS Modules ([#&#8203;534](`webpack-contrib/css-loader#534)) ([b90f492](webpack-contrib/css-loader@b90f492))
#### [0.28.2](webpack-contrib/css-loader@v0.28.1...v0.28.2) (2017-05-22)
##### Bug Fixes

* source maps path on `windows` ([#&#8203;532](`webpack-contrib/css-loader#532)) ([c3d0d91](webpack-contrib/css-loader@c3d0d91))
#### [0.28.1](webpack-contrib/css-loader@v0.28.0...v0.28.1) (2017-05-02)
##### Bug Fixes

* allow to specify a full hostname as a root URL ([#&#8203;521](`webpack-contrib/css-loader#521)) ([06d27a1](webpack-contrib/css-loader@06d27a1))
* case insensitivity of [@&#8203;import] ([#&#8203;514](`webpack-contrib/css-loader#514)) ([de4356b](webpack-contrib/css-loader@de4356b))
* don't handle empty [@&#8203;import] and url() ([#&#8203;513](`webpack-contrib/css-loader#513)) ([868fc94](webpack-contrib/css-loader@868fc94))
* imported variables are replaced in exports if followed by a comma ([#&#8203;504](`webpack-contrib/css-loader#504)) ([956bad7](webpack-contrib/css-loader@956bad7))
* loader now correctly handles `url` with space(s) ([#&#8203;495](`webpack-contrib/css-loader#495)) ([534ea55](webpack-contrib/css-loader@534ea55))
* url with a trailing space is now handled correctly ([#&#8203;494](`webpack-contrib/css-loader#494)) ([e1ec4f2](webpack-contrib/css-loader@e1ec4f2))
* use `btoa` instead `Buffer` ([#&#8203;501](`webpack-contrib/css-loader#501)) ([fbb0714](webpack-contrib/css-loader@fbb0714))
##### Performance Improvements

* generate source maps only when explicitly set ([#&#8203;478](`webpack-contrib/css-loader#478)) ([b8f5c8f](webpack-contrib/css-loader@b8f5c8f))

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
@snyk-bot snyk-bot mentioned this pull request Aug 16, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Jan 8, 2020
Open
This was referenced Jan 22, 2020
Open
Closed
This was referenced Feb 23, 2020
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 7, 2020
Closed
This was referenced Apr 2, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Apr 24, 2020
Open
This was referenced May 4, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bebraw bebraw bebraw approved these changes

@michael-ciniawsky michael-ciniawsky michael-ciniawsky approved these changes

@alexander-akait alexander-akait Awaiting requested review from alexander-akait

@joshwiens joshwiens Awaiting requested review from joshwiens

Assignees

@michael-ciniawsky michael-ciniawsky

Labels
pr_action: Discuss priority: 4 (important) semver: Minor severity: 2 (regression) type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@OliverJAsh @jsf-clabot @alexander-akait @michael-ciniawsky @joshwiens @bebraw