This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
fix(schema): allow additionalProperties
#207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
=======================================
Coverage 96.96% 96.96%
=======================================
Files 2 2
Lines 33 33
Branches 16 16
=======================================
Hits 32 32
Misses 1 1Continue to review full report at Codecov.
|
michael-ciniawsky
requested review from
alexander-akait,
mattlewis92 and
joshwiens
joshwiens
approved these changes
Sep 30, 2017
|
@michael-ciniawsky - Shipping this as we have a broken minor version on npm |
joshwiens
reviewed
Sep 30, 2017
appveyor.yml
Outdated
| job_part: test | ||
| build: 'off' | ||
| matrix: | ||
| fast_finish: true | ||
| install: | ||
| - ps: Install-Product node $env:nodejs_version x64 | ||
| - 'ps: Install-Product node $env:nodejs_version x64' |
There was a problem hiding this comment.
Pull the single quotes off all the powershell commands
joshwiens
reviewed
Sep 30, 2017
.eslintrc
Outdated
| } | ||
| } | ||
| "extends": "webpack" | ||
| } |
There was a problem hiding this comment.
Roll this back to "no-undefined": 0
michael-ciniawsky
force-pushed
the
fix
branch
from
21a1269
to
b4844a7
Compare
|
kk mom :) |
|
And don't forget to brush your teeth before bed ..... |
michael-ciniawsky
force-pushed
the
fix
branch
from
b4844a7
to
82f1e7d
Compare
|
mom === just a moment Is this uncommon to use ? 🙃 😕 |
|
Evidently I'm just getting old ... |
michael-ciniawsky
force-pushed
the
fix
branch
from
82f1e7d
to
794357f
Compare
michael-ciniawsky
added
semver: Patch
status: Approved
and removed
priority: 2 (urgent)
pr_action: Review
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noteable Changes
Allow
addtionalPropertiesforurl-loaderfallback compatIssues