Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pathToArray changing drive letter case for Windows #53

Open
marknadig opened this issue Jan 22, 2018 · 0 comments
Open

pathToArray changing drive letter case for Windows #53

marknadig opened this issue Jan 22, 2018 · 0 comments

Comments

@marknadig
Copy link

pathToArray() unnecessarily changes the drive letter case when not *nix path[0] = path[0].toUpperCase();.

This mutation causes a problem in tasks run from c:. For example, memory-fs-stream _read() will fail because root was "c:..." but they keys on this.fs.data had been changed by pathToArray to "C:"

I don't see a test asserting this behavior. I'm happy to submit a PR, but wanted to verify this behavior wasn't intentional/required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant