Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer is broken for target: "webworker" #60

Open
haggholm opened this issue May 8, 2017 · 0 comments
Open

Buffer is broken for target: "webworker" #60

haggholm opened this issue May 8, 2017 · 0 comments

Comments

@haggholm
Copy link

haggholm commented May 8, 2017

The buffer module currently used (v4) performs a check of a variable explicitly on the global variable, something like if(global.TYPED_ARRAY_SUPPORT). As mentioned in #31, global is not polyfilled—at least it isn’t when building a Webpack bundle for the webworker target. As a result, code that relies on Webpack polyfilling the buffer module will break in webworkers.

This can be trivially fixed by updating to the latest version of the buffer module (5), but in #45 it seems that sticking to an older version is a deliberate decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant