Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer 4.9.1 can cause errors #93

Open
Borewit opened this issue Aug 11, 2019 · 0 comments
Open

buffer 4.9.1 can cause errors #93

Borewit opened this issue Aug 11, 2019 · 0 comments

Comments

@Borewit
Copy link

Borewit commented Aug 11, 2019 •
edited

Calling a read function on the embedded buffer without any argument will throw an exception.
This is major incompatibility issue with node.js buffer.

Error message thrown: "RangeError: offset is not uint"

Corresponding issue: feross/buffer#237

I suggest to reconsider PR: #68, which does fix the issue
@Borewit Borewit mentioned this issue Aug 11, 2019
Closed
ortexx added a commit to ortexx/node-id3 that referenced this issue Sep 21, 2020
@ortexx
Passed arguments everywhere to buffer.readUInt32BE() to avoid some er…
3108fbd 
…rors

webpack/node-libs-browser#93
Webpack 4 now is a stable version. It uses node-libs for Buffer polyfill that is not completely compatible with the nodejs implemintation. In node-libs a lot of optional arguments are required, so we get an offset error in the browser calling buffer.readUInt32BE without an argument.
@ortexx ortexx mentioned this issue Sep 21, 2020
Merged
@Sajjon Sajjon mentioned this issue Jun 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Borewit