Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non-empty validation error message #116

Merged
merged 2 commits into from Nov 7, 2020

Conversation

snitin315
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fix error message

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #116 (e2be8ac) into master (cdbf8b7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #116   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files           6        6           
  Lines         700      700           
  Branches      299      299           
=======================================
  Hits          683      683           
  Misses         15       15           
  Partials        2        2           
Impacted Files Coverage Δ
src/ValidationError.js 96.69% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdbf8b7...e2be8ac. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@alexander-akait alexander-akait merged commit c51abef into webpack:master Nov 7, 2020
@snitin315 snitin315 deleted the fix/err-msg branch November 7, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants