chore: loop change

anikethsaha · anikethsaha · commit 818e43e54a7e · 2019-05-28T14:37:41.000+05:30
changed the loop
diff --git a/packages/generators/utils/plugins.ts b/packages/generators/utils/plugins.ts
@@ -43,11 +43,8 @@ export const replaceAt = (str: string, index: number, replace: string) : string
 export const generatePluginName = (rawPluginName: string): string => {
 	let myPluginNameArray : string[];
 	myPluginNameArray = rawPluginName.split("-");
-	if(myPluginNameArray.length <= 1){}
-	else{
-		for (let i = 0; i < myPluginNameArray.length; i++) {
-			myPluginNameArray[i] = replaceAt(myPluginNameArray[i], 0, myPluginNameArray[i].charAt(0).toUpperCase());
-		}
+	for (let i = 0; i < myPluginNameArray.length && myPluginNameArray.length > 1 ; i++) {
+		myPluginNameArray[i] = replaceAt(myPluginNameArray[i], 0, myPluginNameArray[i].charAt(0).toUpperCase());
 	}
 	return myPluginNameArray.join("")
 }

Original file line number	Diff line number	Diff line change
`@@ -43,11 +43,8 @@ export const replaceAt = (str: string, index: number, replace: string) : string`
`43`	`43`	`export const generatePluginName = (rawPluginName: string): string => {`
`44`	`44`	`let myPluginNameArray : string[];`
`45`	`45`	`myPluginNameArray = rawPluginName.split("-");`
`46`		`- if(myPluginNameArray.length <= 1){}`
`47`		`- else{`
`48`		`- for (let i = 0; i < myPluginNameArray.length; i++) {`
`49`		`- myPluginNameArray[i] = replaceAt(myPluginNameArray[i], 0, myPluginNameArray[i].charAt(0).toUpperCase());`
`50`		`- }`
	`46`	`+ for (let i = 0; i < myPluginNameArray.length && myPluginNameArray.length > 1 ; i++) {`
	`47`	`+ myPluginNameArray[i] = replaceAt(myPluginNameArray[i], 0, myPluginNameArray[i].charAt(0).toUpperCase());`
`51`	`48`	`}`
`52`	`49`	`return myPluginNameArray.join("")`
`53`	`50`	`}`