From 9f350736f936ee610180a9a1cb0ddf108ba31409 Mon Sep 17 00:00:00 2001 From: Pranshu Chittora Date: Wed, 5 Jun 2019 00:28:10 +0530 Subject: [PATCH] chore(utils): refactors ast utils refactored ast utils --- packages/utils/ast-utils.ts | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/packages/utils/ast-utils.ts b/packages/utils/ast-utils.ts index 5ff459b10b1..5b914a00b3d 100644 --- a/packages/utils/ast-utils.ts +++ b/packages/utils/ast-utils.ts @@ -182,7 +182,7 @@ function createLiteral(j: JSCodeshift, val: valueType): Node { literalVal = true; } // 'false' => false - if (val === "false") { + else if (val === "false") { literalVal = false; } // '1' => 1 @@ -585,11 +585,7 @@ function parseTopScope(j: JSCodeshift, ast: Node, value: string[], action: strin ); return false; // TODO: debug later } - if (value) { - return ast.find(j.Program).filter((p: Node): boolean => createTopScopeProperty(p)); - } else { - return ast; - } + return value ? ast.find(j.Program).filter((p: Node): boolean => createTopScopeProperty(p)) : ast; } /** @@ -632,11 +628,7 @@ function parseMerge(j: JSCodeshift, ast: Node, value: string, action: string): b (p.value as Node).body[bodyLength - 1] = newVal; return false; // TODO: debug later } - if (value) { - return ast.find(j.Program).filter((p: Node): boolean => createMergeProperty(p)); - } else { - return ast; - } + return value ? ast.find(j.Program).filter((p: Node): boolean => createMergeProperty(p)) : ast; } export {