From fb25bd2cb1d72def40e14ba431fe368cd6df6653 Mon Sep 17 00:00:00 2001 From: Devid Farinelli Date: Wed, 29 May 2019 16:03:20 +0200 Subject: [PATCH] tests(inputvalidate): remove undefined --- .../__tests__/__snapshots__/index.test.ts.snap | 1 - packages/webpack-scaffold/__tests__/index.test.ts | 1 - packages/webpack-scaffold/index.ts | 5 +++-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/webpack-scaffold/__tests__/__snapshots__/index.test.ts.snap b/packages/webpack-scaffold/__tests__/__snapshots__/index.test.ts.snap index 0e06b120337..2bb1ed2117f 100755 --- a/packages/webpack-scaffold/__tests__/__snapshots__/index.test.ts.snap +++ b/packages/webpack-scaffold/__tests__/__snapshots__/index.test.ts.snap @@ -2,7 +2,6 @@ exports[`utils Inquirer should make an Input object with validation 1`] = ` Object { - "default": undefined, "message": "what is your plugin?", "name": "plugins", "type": "input", diff --git a/packages/webpack-scaffold/__tests__/index.test.ts b/packages/webpack-scaffold/__tests__/index.test.ts index 586bbcd9a58..2d0ccef8582 100755 --- a/packages/webpack-scaffold/__tests__/index.test.ts +++ b/packages/webpack-scaffold/__tests__/index.test.ts @@ -76,7 +76,6 @@ describe("utils", () => { }); it("should make an Input object", () => { expect(utils.Input("plugins", "what is your plugin?")).toEqual({ - default: undefined, message: "what is your plugin?", name: "plugins", type: "input", diff --git a/packages/webpack-scaffold/index.ts b/packages/webpack-scaffold/index.ts index 6477030c331..8eea29f9f95 100755 --- a/packages/webpack-scaffold/index.ts +++ b/packages/webpack-scaffold/index.ts @@ -92,13 +92,14 @@ export function InputValidate( defaultChoice?: string, ): Generator.Question { - return { - default: defaultChoice, + const input: Generator.Question = { message, name, type: "input", validate: cb }; + if (defaultChoice !== undefined) input.default = defaultChoice; + return input; } export function Confirm(name: string, message: string, defaultChoice: boolean = true): Generator.Question {