Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: webpack/webpack-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.3.8
Choose a base ref
...
head repository: webpack/webpack-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.3.9
Choose a head ref
  • 3 commits
  • 4 files changed
  • 2 contributors

Commits on Sep 13, 2019

  1. Copy the full SHA
    ee001bd View commit details

Commits on Sep 17, 2019

  1. Merge pull request #1078 from lneveu/fix/process-exit-hang

    fix: fix webpack hanging under certain circumstance
    evenstensberg authored Sep 17, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    a1341bd View commit details
  2. chore: v3.3.9

    evenstensberg committed Sep 17, 2019

    Verified

    This commit was signed with the committer’s verified signature.
    evenstensberg Even Stensberg
    Copy the full SHA
    48c03ab View commit details
Showing with 14 additions and 3 deletions.
  1. +10 −0 CHANGELOG.md
  2. +2 −1 bin/cli.js
  3. +1 −1 package-lock.json
  4. +1 −1 package.json
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
<a name="3.3.9"></a>

# 3.3.9 (2019-09-17)

[Full Changelog](https://github.com/webpack/webpack-cli/compare/v3.3.8...v3.3.9)

## Fix

- use process.exitCode instead of process.exit in compilerCallback ([ee001bd](https://github.com/webpack/webpack-cli/commit/ee001bd))

<a name="3.3.8"></a>

# 3.3.8 (2019-09-05)
3 changes: 2 additions & 1 deletion bin/cli.js
Original file line number Diff line number Diff line change
@@ -314,7 +314,8 @@ For more information, see https://webpack.js.org/api/cli/.`);
lastHash = null;
console.error(err.stack || err);
if (err.details) console.error(err.details);
process.exit(1); // eslint-disable-line
process.exitCode = 1;
return;
}
if (outputOptions.json) {
stdout.write(JSON.stringify(stats.toJson(outputOptions), null, 2) + "\n");
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "webpack-cli",
"version": "3.3.8",
"version": "3.3.9",
"description": "CLI for webpack & friends",
"license": "MIT",
"repository": {