Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli-executer supplies args further up #1904

Merged
merged 3 commits into from Oct 10, 2020

Conversation

jamesgeorge007
Copy link
Member

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
Updated existing tests.

If relevant, did you update the documentation?
N/A

Summary
closes #1901

Does this PR introduce a breaking change?
Nope

Other information
N/A

@jamesgeorge007 jamesgeorge007 added the Semver: patch 🔧 Usually for bugfixes label Oct 10, 2020
@jamesgeorge007 jamesgeorge007 requested a review from a team as a code owner October 10, 2020 09:17
@jamesgeorge007 jamesgeorge007 force-pushed the hotfix/cli-executer branch 4 times, most recently from 3127aba to 2450de2 Compare October 10, 2020 13:14
} catch (err) {
logger.error(`Action Interrupted, use ${cyan('webpack-cli help')} to see possible options.`);
process.exit(2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webpack/cli-team we need tests this, let's do it in separate PR, because we need do release today

@alexander-akait alexander-akait merged commit 097564a into webpack:next Oct 10, 2020
@jamesgeorge007 jamesgeorge007 deleted the hotfix/cli-executer branch October 10, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli executer fails to invoke runCLI()
5 participants