fix: avoid unnecessary stringify #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshumanv
previously approved these changes
Oct 11, 2020
alexander-akait
force-pushed
the
fix-1919
branch
from
eedce42
to
f333987
Compare
alexander-akait
force-pushed
the
fix-1919
branch
from
f333987
to
70ba799
Compare
|
@anshumanv Added tests on build errors and build warnings |
anshumanv
previously approved these changes
Oct 11, 2020
alexander-akait
force-pushed
the
fix-1919
branch
from
231e62e
to
6fa0abb
Compare
|
CI config has updated too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
No, existing
If relevant, did you update the documentation?
No, unnecessary
Summary
Don't know why we use
JSON.stringifyon JSONDoes this PR introduce a breaking change?
No
Other information
I think it should fix #1919