feat: allow passing strings in env flag #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good to update the new --env approach at https://webpack.js.org/api/cli/ and also explain how to migrate to version 5 at https://webpack.js.org/migrate/5/ |
|
Yep, @paulmackinlay I have a PR already - webpack/webpack.js.org#4051 hoping it's merged soon. |
|
/cc @anshumanv please focus on it |
anshumanv
commented
Oct 15, 2020
marques-work
added a commit
to gocd/gocd
that referenced
this pull request
Oct 15, 2020
…merged and released
|
Release new version? :D |
This was referenced Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feat/fix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Need to reflect in docs
Summary
webpack --env platform=app --env productionwhich will pass
{ platform: "app", production: true }to the configDoes this PR introduce a breaking change?
Nope
Other information
Fixes #1932