Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: colored output #1944

Merged
merged 5 commits into from Oct 14, 2020
Merged

fix: colored output #1944

merged 5 commits into from Oct 14, 2020

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

fix

Did you add tests for your changes?

yes

If relevant, did you update the documentation?

No need

Summary

fixes #1915

Does this PR introduce a breaking change?

No

Other information

No

Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, mostly looks good

});

it('should work with the "stats" option from the configuration', () => {
const { stderr, stdout, exitCode } = run(__dirname, [`--config=${resolve(__dirname, './stats-string.webpack.config.js')}`]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can give relative path,

Suggested change
const { stderr, stdout, exitCode } = run(__dirname, [`--config=${resolve(__dirname, './stats-string.webpack.config.js')}`]);
const { stderr, stdout, exitCode } = run(__dirname, ['-c', './stats-string.webpack.config.js']);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to use aliases in tests, except tests on aliases, we can rename them (this can happen more often than renaming basic options)

expect(exitCode).toBe(0);
});

it('should work with the "stats" option from the configuration #4', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add tests with both config and flags?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to do it after this will be merged, I really don't have time to solve all problems from previously webpack-cli contrbutors, I'm very disappointed, I want to fix basic regressions and rewrite most of code, because here bug on almost every line of code

@alexander-akait alexander-akait merged commit 2bbbb14 into master Oct 14, 2020
@alexander-akait alexander-akait deleted the issue-1915 branch October 14, 2020 14:17
@alexander-akait
Copy link
Member Author

We need more tests, put it in TODO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4: stats colors not enabled by default
3 participants