Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: --config-name behaviour for fuctional configs #2006

Merged
merged 9 commits into from Nov 3, 2020
Merged

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
fix

Did you add tests for your changes?
yes
If relevant, did you update the documentation?
No
Summary

Fixes #1990

Does this PR introduce a breaking change?
No

Other information

@snitin315 snitin315 requested a review from a team as a code owner November 1, 2020 02:08
@snitin315 snitin315 marked this pull request as draft November 1, 2020 02:50
@snitin315 snitin315 marked this pull request as ready for review November 1, 2020 03:35
@snitin315
Copy link
Member Author

/cc @webpack/cli-team

@snitin315
Copy link
Member Author

Should be good now.

rishabh3112
rishabh3112 previously approved these changes Nov 3, 2020
@@ -172,7 +174,15 @@ const finalize = async (moduleObj, args) => {

return rawConfig;
}),
);
).then((allConfigs) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using then, we can use async/await safely, I think we need eslint rule for this

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway good job, thanks!

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix tests and we can merge

@snitin315
Copy link
Member Author

Green CI 😄

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team

@snitin315 snitin315 merged commit 29ecf8d into master Nov 3, 2020
@snitin315 snitin315 deleted the fix/config-name branch November 3, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--config-name fails for a function returning an array of configurations
5 participants