Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack-cli@v4.2.0 breaks color support on CI/CD #2038

Closed
proton-ab opened this issue Nov 4, 2020 · 4 comments · Fixed by #2042
Closed

webpack-cli@v4.2.0 breaks color support on CI/CD #2038

proton-ab opened this issue Nov 4, 2020 · 4 comments · Fixed by #2042
Labels

Comments

@proton-ab
Copy link

proton-ab commented Nov 4, 2020

Describe the bug

Automated color detection was broken in v4.0.0 and subsequently fixed in v4.1.0. It is now broken again in v4.2.0 but only partially. The removal of --color flag also means we can not override this behavior and are left with uncolored output on CI.

Expected behavior

Either color support is properly detected or an override flag is provided again.

Screenshots

v4.1.0:
firefox_2020-11-04_21-44-42

v4.2.0:
firefox_2020-11-04_21-44-59

Please note that Drone fully supports ANSI colors but might not be properly detected by some tools (or outright blocked due to CI environment variable being detected)

@proton-ab proton-ab added the Bug label Nov 4, 2020
@proton-ab proton-ab changed the title Webpack@v4.2.0 breaks color support on CI/CD webpack-cli@v4.2.0 breaks color support on CI/CD Nov 4, 2020
@snitin315
Copy link
Member

Thanks for the report. I'm looking into it.

@snitin315
Copy link
Member

snitin315 commented Nov 5, 2020

The removal of --color flag also means we can not override this behavior and are left with uncolored output

We still support --color flag. You can use it.

EDIT: --color is true by default so no need to pass it explicitly.

@proton-ab
Copy link
Author

We still support --color flag. You can use it.

Was going by comment #1967 (comment)

@alexander-akait
Copy link
Member

Note for myself:

// webpack.config.js
module.exports = [{
    entry: './src/index.js',
},
{
    entry: './src/index.js',
}];

adding test for multi compiler mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants