Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to pass parseOption to CLI class #2299

Merged
merged 2 commits into from Jan 3, 2021
Merged

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

feature

Did you add tests for your changes?

No, it is for future tests and public API

If relevant, did you update the documentation?

No need right now, it is not public

Summary

For tests

Does this PR introduce a breaking change?

No

Other information

Fix export, bevause we don't have commands right now, and we should pass cli instance to commands instead export utils

@codecov
Copy link

codecov bot commented Jan 3, 2021

Codecov Report

Merging #2299 (692723a) into master (0191ebc) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2299      +/-   ##
==========================================
- Coverage   67.78%   67.76%   -0.02%     
==========================================
  Files          63       63              
  Lines        2483     2482       -1     
  Branches      570      570              
==========================================
- Hits         1683     1682       -1     
  Misses        800      800              
Impacted Files Coverage Δ
packages/webpack-cli/lib/index.js 100.00% <100.00%> (ø)
packages/webpack-cli/lib/webpack-cli.js 89.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0191ebc...692723a. Read the comment docs.

@alexander-akait alexander-akait merged commit 2af0801 into master Jan 3, 2021
@alexander-akait alexander-akait deleted the issue-2280 branch January 3, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants