Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect --stats, --color and --no-color option for serve c… #2312

Merged

Conversation

alexander-akait
Copy link
Member

…ommand

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

partial

If relevant, did you update the documentation?

No need

Summary

respect --stats, --color and --no-color options for webpack serve

Does this PR introduce a breaking change?

No

Other information

Here PR to respect colors - webpack/webpack-dev-middleware#808

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #2312 (f17ec45) into master (19a25cf) will decrease coverage by 0.14%.
The diff coverage is 94.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2312      +/-   ##
==========================================
- Coverage   67.83%   67.68%   -0.15%     
==========================================
  Files          63       63              
  Lines        2487     2510      +23     
  Branches      572      588      +16     
==========================================
+ Hits         1687     1699      +12     
- Misses        800      811      +11     
Impacted Files Coverage Δ
packages/serve/src/startDevServer.ts 83.60% <86.95%> (-0.40%) ⬇️
packages/webpack-cli/lib/webpack-cli.js 89.69% <97.77%> (+0.10%) ⬆️
packages/serve/src/index.ts 64.28% <100.00%> (ø)
packages/generators/src/utils/webpackConfig.ts 20.00% <0.00%> (-80.00%) ⬇️
packages/generators/src/utils/tooltip.ts 45.45% <0.00%> (-36.37%) ⬇️
packages/generators/src/init-generator.ts 93.81% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19a25cf...f17ec45. Read the comment docs.

@alexander-akait
Copy link
Member Author

We need refactor tests which change cwd

@alexander-akait alexander-akait merged commit 73d3fec into master Jan 6, 2021
@alexander-akait alexander-akait deleted the fix-respect-stats-and-color-for-serve-command branch January 6, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants