Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webpack installation prompt message #2316

Merged
merged 1 commit into from Jan 6, 2021
Merged

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
fix

Did you add tests for your changes?
no
If relevant, did you update the documentation?
no
Summary

Earlier it was -

Screenshot at 2021-01-06 17-37-37

Does this PR introduce a breaking change?
NO

Other information
No

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #2316 (508c0db) into master (4ea0cb4) will decrease coverage by 0.36%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2316      +/-   ##
==========================================
- Coverage   67.81%   67.45%   -0.37%     
==========================================
  Files          63       63              
  Lines        2486     2483       -3     
  Branches      572      572              
==========================================
- Hits         1686     1675      -11     
- Misses        800      808       +8     
Impacted Files Coverage Δ
packages/webpack-cli/bin/cli.js 55.00% <0.00%> (ø)
packages/generators/src/utils/webpackConfig.ts 20.00% <0.00%> (-80.00%) ⬇️
packages/generators/src/utils/tooltip.ts 45.45% <0.00%> (-36.37%) ⬇️
packages/generators/src/init-generator.ts 93.81% <0.00%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ea0cb4...508c0db. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random fail on CI, I am continue fixing theses tests, but let's merge this PR, because fail not related to this CI problem

@alexander-akait alexander-akait merged commit 3659c5e into master Jan 6, 2021
@alexander-akait alexander-akait deleted the fix/webpack-msg branch January 6, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants