Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix entries syntax #2369

Merged
merged 18 commits into from Jan 27, 2021
Merged

[WIP] Fix entries syntax #2369

merged 18 commits into from Jan 27, 2021

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Jan 20, 2021

What kind of change does this PR introduce?

feature

Did you add tests for your changes?

Yes

If relevant, did you update the documentation?

Yes:

  • webpack ./entry.js --mode=development
  • webpack ./entry.js ./other.js --mode=development
  • webpack build ./entry.js --mode=development
  • webpack build ./entry.js ./other.js --mode=development
  • webpack watch ./entry.js --mode=development
  • webpack serve ./entry.js --mode=development

Summary

fixes #2356

Does this PR introduce a breaking change?

No

Other information

WIP

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #2369 (cfeb158) into master (c5a06f7) will increase coverage by 0.40%.
The diff coverage is 96.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2369      +/-   ##
==========================================
+ Coverage   70.09%   70.50%   +0.40%     
==========================================
  Files          48       47       -1     
  Lines        2117     2156      +39     
  Branches      548      561      +13     
==========================================
+ Hits         1484     1520      +36     
- Misses        633      636       +3     
Impacted Files Coverage Δ
packages/webpack-cli/lib/webpack-cli.js 91.25% <96.60%> (+0.32%) ⬆️
packages/serve/src/index.ts 84.21% <100.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a06f7...cfeb158. Read the comment docs.

evenstensberg
evenstensberg previously approved these changes Jan 21, 2021
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexander-akait
Copy link
Member Author

Still WIP, entry=./entry.js is not supported here

@alexander-akait alexander-akait changed the title Fix entries syntax [WIP] Fix entries syntax Jan 22, 2021
@alexander-akait
Copy link
Member Author

alexander-akait commented Jan 26, 2021

Impossible to implement:

- `webpack entry=./entry.js --mode=development` (WIP)
- `webpack entry=./entry.js other=./other.js --mode=development` (WIP)

We need new this on webpack side, webpack accept only string or array of strings (put in my todo)

This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Did you mean '--entry index.js'?"
3 participants