Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix error message on invalid plugin options #2380

Merged
merged 2 commits into from Jan 28, 2021

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

yes

If relevant, did you update the documentation?

No need

Summary

We should not output error stack for validation errors inside plugins

Does this PR introduce a breaking change?

No

Other information

No

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #2380 (c1fbfbe) into master (311bae3) will increase coverage by 0.02%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2380      +/-   ##
==========================================
+ Coverage   70.50%   70.52%   +0.02%     
==========================================
  Files          47       47              
  Lines        2156     2158       +2     
  Branches      561      563       +2     
==========================================
+ Hits         1520     1522       +2     
  Misses        636      636              
Impacted Files Coverage Δ
packages/serve/src/index.ts 84.21% <0.00%> (ø)
packages/webpack-cli/lib/webpack-cli.js 91.27% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 311bae3...c1fbfbe. Read the comment docs.

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀 .

@alexander-akait alexander-akait merged commit f9ce1d3 into master Jan 28, 2021
@alexander-akait alexander-akait deleted the fix-error-message-on-invalid-plugin-options branch January 28, 2021 14:03
snitin315 pushed a commit to snitin315/webpack-cli that referenced this pull request Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants