Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show '--node-env' in minimum help output #2411

Merged
merged 2 commits into from Feb 8, 2021
Merged

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
already present.

If relevant, did you update the documentation?
Yes
Summary
Show --node-env in minimum help output as it is custom flag provided by CLI. --help=verbose lists too many options not easy to find --node-env between them.

Screenshot at 2021-02-04 16-49-34

Does this PR introduce a breaking change?
No

Other information
No

@snitin315 snitin315 requested a review from a team as a code owner February 4, 2021 11:20
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #2411 (59af519) into master (78e2fa7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2411   +/-   ##
=======================================
  Coverage   71.79%   71.79%           
=======================================
  Files          46       46           
  Lines        2177     2177           
  Branches      574      574           
=======================================
  Hits         1563     1563           
  Misses        614      614           
Impacted Files Coverage Δ
packages/webpack-cli/lib/webpack-cli.js 91.92% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e2fa7...59af519. Read the comment docs.

alexander-akait
alexander-akait previously approved these changes Feb 4, 2021
@alexander-akait
Copy link
Member

@snitin315 Can you rebase?

alexander-akait
alexander-akait previously approved these changes Feb 6, 2021
Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can assert on it in help output test

@alexander-akait
Copy link
Member

I think we need to use snapshots for help and output, it will allow us to see all the changes.

@anshumanv
Copy link
Member

yep snapshot is better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants