Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow string value for '--hot' #2444

Merged
merged 2 commits into from Mar 15, 2021
Merged

feat: allow string value for '--hot' #2444

merged 2 commits into from Mar 15, 2021

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
yes, serve tests can be added after upgrade to v4.
If relevant, did you update the documentation?
Yes
Summary

Allow string value for --hot, --hot=only is accepted by webpack-dev-server

Does this PR introduce a breaking change?
No

Other information
No

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #2444 (db3c6a6) into master (74ed07b) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2444      +/-   ##
==========================================
+ Coverage   71.86%   71.89%   +0.03%     
==========================================
  Files          46       46              
  Lines        2182     2185       +3     
  Branches      581      582       +1     
==========================================
+ Hits         1568     1571       +3     
  Misses        614      614              
Impacted Files Coverage Δ
packages/webpack-cli/lib/webpack-cli.js 91.95% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74ed07b...db3c6a6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants