Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add WEBPACK_PACKAGE env var to use custom webpack package #2556

Merged
merged 2 commits into from Mar 26, 2021

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Mar 25, 2021

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
will send PR to documentation
Summary
FIxes #2551

"webpack": "^4.0.0",
"webpack5": "npm:webpack@^5.28.0",
"webpack-cli": "^4.5.0"

webpack - run webpack 4
WEBPACK_PACKAGE=webpack5 - run webpack 5

Does this PR introduce a breaking change?
No

Other information
No

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need test, test/build/custom-webpack/custom-webpack.js with module.exports = require('webpack') and set WEBPACK_PACKAGE=./custom-webpack.js

@snitin315 snitin315 changed the title feat: add WEBPACK_PACKAGE env var to switch between versions of webpack feat: add WEBPACK_PACKAGE env var to use webpack package Mar 25, 2021
@snitin315 snitin315 changed the title feat: add WEBPACK_PACKAGE env var to use webpack package feat: add WEBPACK_PACKAGE env var to use custom webpack package Mar 25, 2021
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #2556 (38cddca) into master (d039472) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2556      +/-   ##
==========================================
+ Coverage   90.98%   91.12%   +0.13%     
==========================================
  Files          29       29              
  Lines        1464     1464              
  Branches      419      420       +1     
==========================================
+ Hits         1332     1334       +2     
+ Misses        132      130       -2     
Impacted Files Coverage Δ
packages/webpack-cli/lib/webpack-cli.js 92.41% <100.00%> (ø)
packages/webpack-cli/lib/bootstrap.js 100.00% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d039472...38cddca. Read the comment docs.

@snitin315 snitin315 marked this pull request as ready for review March 25, 2021 14:15
@snitin315 snitin315 requested a review from a team as a code owner March 25, 2021 14:15
@snitin315
Copy link
Member Author

added tests 👍🏻

anshumanv
anshumanv previously approved these changes Mar 25, 2021
@snitin315
Copy link
Member Author

Cache issue?

@alexander-akait
Copy link
Member

Yep, happens only on windows

@alexander-akait
Copy link
Member

@snitin315 Let's wait green #2553 and merge, then rebase

@anshumanv
Copy link
Member

lets rebase

@snitin315 snitin315 merged commit 3d1e485 into master Mar 26, 2021
@snitin315 snitin315 deleted the feat/env-var branch March 26, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Option to switch between versions of webpack
4 participants