Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configs property for --devtool #2603

Merged
merged 3 commits into from Apr 7, 2021
Merged

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary

devtool can also accept false.

Does this PR introduce a breaking change?
No

Other information
None

@snitin315 snitin315 requested a review from a team as a code owner April 6, 2021 12:04
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only for webpack v5, we already support it

@snitin315
Copy link
Member Author

I see then we should remove negative: true?

@snitin315
Copy link
Member Author

@alexander-akait
Copy link
Member

yep, okay, let's do it, but I don't want to accept any bugfixes/features (expect security bugs for v4), because when we will drop webpack v4 we will remove these flags

@snitin315
Copy link
Member Author

Makes sense 👍🏻

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #2603 (0a8ef27) into master (3a5cf10) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2603   +/-   ##
=======================================
  Coverage   91.35%   91.35%           
=======================================
  Files          29       29           
  Lines        1480     1480           
  Branches      425      425           
=======================================
  Hits         1352     1352           
  Misses        128      128           
Impacted Files Coverage Δ
packages/webpack-cli/lib/webpack-cli.js 92.41% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a5cf10...0a8ef27. Read the comment docs.

@snitin315
Copy link
Member Author

/cc @webpack/cli-team

@alexander-akait alexander-akait merged commit 7c6f390 into master Apr 7, 2021
@alexander-akait alexander-akait deleted the fix/devtool-config branch April 7, 2021 12:35
@alexander-akait
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants