Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prettier config #2719

Merged
merged 3 commits into from May 15, 2021
Merged

fix: prettier config #2719

merged 3 commits into from May 15, 2021

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?
build

Did you add tests for your changes?
NA

If relevant, did you update the documentation?
NA

Summary
Updates prettier config to use sensible defaults

Does this PR introduce a breaking change?
no

Other information

@anshumanv anshumanv requested a review from a team as a code owner May 15, 2021 12:39
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team

@codecov
Copy link

codecov bot commented May 15, 2021

Codecov Report

Merging #2719 (d00c010) into master (244277d) will increase coverage by 0.06%.
The diff coverage is 96.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2719      +/-   ##
==========================================
+ Coverage   96.06%   96.13%   +0.06%     
==========================================
  Files          30       30              
  Lines        1526     1604      +78     
  Branches      432      471      +39     
==========================================
+ Hits         1466     1542      +76     
- Misses         60       62       +2     
Impacted Files Coverage Δ
packages/generators/addon-template/package.json.js 100.00% <ø> (ø)
packages/generators/src/loader-generator.ts 91.66% <75.00%> (ø)
packages/webpack-cli/bin/cli.js 66.66% <81.81%> (ø)
...kages/webpack-cli/lib/utils/get-package-manager.js 92.30% <88.23%> (ø)
packages/serve/src/index.ts 91.17% <91.66%> (+0.55%) ⬆️
packages/generators/src/addon-generator.ts 91.37% <92.85%> (+0.15%) ⬆️
packages/serve/src/startDevServer.ts 93.33% <92.85%> (+0.35%) ⬆️
packages/generators/src/init-generator.ts 98.07% <94.73%> (ø)
packages/webpack-cli/lib/webpack-cli.js 97.12% <96.80%> (-0.04%) ⬇️
packages/generators/src/handlers/default.ts 98.50% <97.50%> (+0.02%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 244277d...d00c010. Read the comment docs.

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks okay for me.

@alexander-akait alexander-akait merged commit 181295f into master May 15, 2021
@alexander-akait alexander-akait deleted the pret branch May 15, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants