Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(init-generator): add ability to specify a package manager of choice #2769

Merged
merged 3 commits into from Jun 9, 2021

Conversation

jamesgeorge007
Copy link
Member

What kind of change does this PR introduce?
Feature

Did you add tests for your changes?
Update test suite

If relevant, did you update the documentation?
N/A

Summary
#2768

webpack-init

Does this PR introduce a breaking change?
No

Other information
N/A

alexander-akait
alexander-akait previously approved these changes Jun 7, 2021
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix CI

evenstensberg
evenstensberg previously approved these changes Jun 8, 2021
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jamesgeorge007 jamesgeorge007 marked this pull request as ready for review June 9, 2021 14:00
@jamesgeorge007 jamesgeorge007 requested a review from a team as a code owner June 9, 2021 14:00
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #2769 (b4ef065) into master (59d644d) will decrease coverage by 0.05%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2769      +/-   ##
==========================================
- Coverage   94.10%   94.05%   -0.06%     
==========================================
  Files          31       32       +1     
  Lines        1680     1698      +18     
  Branches      490      490              
==========================================
+ Hits         1581     1597      +16     
- Misses         99      101       +2     
Impacted Files Coverage Δ
.../webpack-cli/lib/utils/get-available-installers.js 86.66% <86.66%> (ø)
packages/generators/src/init-generator.ts 98.11% <100.00%> (+0.03%) ⬆️
packages/webpack-cli/lib/utils/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d644d...b4ef065. Read the comment docs.

@jamesgeorge007 jamesgeorge007 merged commit e53f164 into master Jun 9, 2021
@jamesgeorge007 jamesgeorge007 deleted the feat/init-generator branch June 9, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants