Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: npx init #2980

Merged
merged 1 commit into from Oct 2, 2021
Merged

fix: npx init #2980

merged 1 commit into from Oct 2, 2021

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Oct 1, 2021

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

manually tests

If relevant, did you update the documentation?

yes

/cc @webpack/cli-team we need update our docs, for init we should always use npx webpack-cli init

Summary

It is fast fix, in future we should create rename init to create-webpack-app and use npx create-webpack-app

Does this PR introduce a breaking change?

No

Other information

Partial fix #2944

@alexander-akait
Copy link
Member Author

No npx install webpack-cli inself, because we need this package and allow to run init

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #2980 (33a30de) into master (d0bce0b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2980   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files          22       22           
  Lines        1650     1650           
  Branches      484      484           
=======================================
  Hits         1567     1567           
  Misses         83       83           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0bce0b...33a30de. Read the comment docs.

@alexander-akait alexander-akait merged commit 1d38499 into master Oct 2, 2021
@alexander-akait alexander-akait deleted the fix-init branch October 2, 2021 14:40
anshumanv pushed a commit that referenced this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This happens when I use npx webpack init. I worked around it by doing ./node_modules/bin/webpack init.
2 participants