fix: remove v8-compile-cache #3006
Merged
+3
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshumanv
commented
Oct 17, 2021
| @@ -246,7 +246,6 @@ class WebpackCLI { | |||
| } catch (error) { | |||
| let previousModuleCompile; | |||
|
|
|||
| // TODO Workaround https://github.com/zertosh/v8-compile-cache/issues/30 | |||
| if (this._originalModuleCompile) { | |||
There was a problem hiding this comment.
Let me also remove this workaround logic
Codecov Report
@@ Coverage Diff @@
## master #3006 +/- ##
==========================================
- Coverage 94.89% 94.86% -0.04%
==========================================
Files 22 22
Lines 1625 1615 -10
Branches 482 480 -2
==========================================
- Hits 1542 1532 -10
Misses 83 83
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix
Did you add tests for your changes?
Not yet
If relevant, did you update the documentation?
NA
Summary
Removes v8-compile-cache package which creates problems while using with ESM
Does this PR introduce a breaking change?
no, initiation time will be slightly more
Other information
Fix #3005